Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: 578 ๊ฐ•์˜ ์‹ ์ฒญ ๊ฒฐ๊ณผ ๊ฐ•์˜๋ณ„ ์ถœ๋ ฅ API #579

Merged
merged 4 commits into from
Sep 12, 2024
Merged

๐Ÿ”€ :: 578 ๊ฐ•์˜ ์‹ ์ฒญ ๊ฒฐ๊ณผ ๊ฐ•์˜๋ณ„ ์ถœ๋ ฅ API #579

merged 4 commits into from
Sep 12, 2024

Conversation

KimTaeO
Copy link
Collaborator

@KimTaeO KimTaeO commented Sep 12, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์š”๊ตฌ์‚ฌํ•ญ์— ๋”ฐ๋ผ ๊ฐ•์˜๋ณ„๋กœ ์‹œํŠธ๋ฅผ ๋‚˜๋ˆ„์–ด ์‹ ์ฒญ ๊ฒฐ๊ณผ๋ฅผ ์ถœ๋ ฅํ•˜๋Š” API๋ฅผ ์ž‘์„ฑํ•˜๊ฒŒ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค

Resolves: #578

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

์ž‘์—…์„ ๋๋‚ด์•ผํ•  ์‹œ๊ฐ„์ด ์–ผ๋งˆ ์—†์–ด ์„ฑ๋Šฅ๋ณด๋‹ค๋Š” ๋™์ž‘์„ ์œ„์ฃผ๋กœ ๋งŒ๋“ค์—ˆ์Šต๋‹ˆ๋‹ค

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@KimTaeO KimTaeO linked an issue Sep 12, 2024 that may be closed by this pull request
๊ฐ•์˜ ์—‘์…€ ์ถœ๋ ฅ ๊ฐ•์˜๋ณ„ ์‹ ์ฒญํ˜„ํ™ฉ API #578
Closed
@KimTaeO KimTaeO self-assigned this Sep 12, 2024
@KimTaeO KimTaeO added the 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ label Sep 12, 2024
@KimTaeO KimTaeO merged commit 90d788c into master Sep 12, 2024
1 check passed
@KimTaeO KimTaeO deleted the 578-feat/lecture-excel-print-by-lecture branch September 12, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ani2689 ani2689 ani2689 approved these changes

@JuuuuHong JuuuuHong JuuuuHong approved these changes

Assignees

@KimTaeO KimTaeO

Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๊ฐ•์˜ ์—‘์…€ ์ถœ๋ ฅ ๊ฐ•์˜๋ณ„ ์‹ ์ฒญํ˜„ํ™ฉ API
3 participants
@KimTaeO @JuuuuHong @ani2689