Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
71 feat/student activity list #77
71 feat/student activity list #77
Changes from all commits
86bb0a1
65039dd
a8afa4a
35bf322
397a27c
8f2228c
835a88b
e0668c1
0f7b5f4
a965d4a
af8be2f
06268d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ToOne κ΄κ³μμλ νμ΄μ§ κ΄λ ¨ μ‘°νλΌλ μ‘°μΈμ μ¬μ©ν΄μ N + 1μ ν΄κ²°ν΄λλλ©°
@EntityGraph
λ₯Ό μ¬μ©νλ κ²λ λ°©λ²μΌ μ μμ΅λλ€. μΆκ°λ‘@BatchSize
μ΄λ Έν μ΄μ μ μ¬μ©ν΄ μ΅λ λ°°μΉ μ¬μ΄μ¦λ₯Ό μ§μ ν΄μ μ±λ₯μ ν₯μμν€λ μ¬λ¬κ°μ§ λ°©λ²μ κ³ λ €ν΄λ³΄μ ¨μΌλ©΄ μ’κ² μ΅λλ€.μ΄ κΈμ μ°Έκ³ ν΄λ³΄μΈμ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μΌλ¨μ StudentActivityRepositoryμμ findAllν κ²½μ°μ @entitygraphλ₯Ό ν΅νμ¬ N+1 λ¬Έμ λ₯Ό ν΄κ²°νμμΌλ©°, @batchsizeλ ~ToManyκ΄κ³μμ μ¬μ©μ μ£Όλ‘ νλ€κ³ νλκ΅°μ. λμ€μ μ 체 μ‘°νκ° μλ νμ μ‘°νλ₯Ό νκ² λλ€λ©΄ νμκ³Ό νμνλ κ°μ μλ°©ν₯ 맀νμ νμ¬ μ μ©μ νλ κ²μ κ³ λ € ν΄λ³΄λλ‘ νκ² μ΅λλ€ κ·Έλ¦¬κ³ λ€λ₯Έ μ½λμμλ N + 1 λ¬Έμ κ° λ°μνλ μ½λλ€μ΄ μλκ΅°μ κ·Έ λΆλΆμ λ°λ‘ Issueλ₯Ό ν΅ν΄ ν΄κ²°ν΄λ³΄λλ‘ νκ² μ΅λλ€
0f7b5f4