feat(OnyxFormElement): Implement success messages to OnyxFormElement #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JoCa96
requested changes
Nov 7, 2024
Comment on lines
29
to
31
| * Configures if success state is shown. | ||
| * When `true`, success state will be shown. | ||
| * When `false`, success state will never be shown. |
There was a problem hiding this comment.
I am unsure if we want the success state to be shown for all form elements at once.
I would like to ask @jannick-ux if that is a use-case we want to support, or if it only should be used sporadically.
Suggested change
| * Configures if success state is shown. | |
| * When `true`, success state will be shown. | |
| * When `false`, success state will never be shown. | |
| * Toggle success state for all form elements. |
…3-Implement-success-messages-to-OnyxFormElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #573
Implement success messages to OnyxFormElement and success state of OnyxInput