Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Stepper API #2416

Merged
merged 13 commits into from
Jan 7, 2025
Merged

Conversation

ChristianBusshoff
Copy link
Contributor

  • changed precision, stepSize and validStepSize

@ChristianBusshoff ChristianBusshoff requested a review from a team as a code owner December 26, 2024 11:47
Copy link

changeset-bot bot commented Dec 26, 2024

🦋 Changeset detected

Latest commit: ab55c88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sit-onyx Major
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MajaZarkova MajaZarkova self-assigned this Dec 27, 2024
larsrickert and others added 5 commits January 2, 2025 14:45
PR review feedback/changes for #2416

Changes:
- update changeset
- update tests
- remove unused `step` and `stripStep` property as well as code to no
longer modify the user entered value when `validStepSize` is set
@larsrickert larsrickert dismissed MajaZarkova’s stale review January 7, 2025 09:53

feedback implemented

@larsrickert larsrickert added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 9e53a89 Jan 7, 2025
21 checks passed
@larsrickert larsrickert deleted the feat/2085-implement-updated-OnyxStepper-API branch January 7, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants