Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OnyxTooltip): fixed alignment of tooltip #2418

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

ChristianBusshoff
Copy link
Contributor

  • added wedgePointsToCenter attribute to fix the issue

@ChristianBusshoff ChristianBusshoff requested a review from a team as a code owner December 27, 2024 09:47
Copy link

changeset-bot bot commented Dec 27, 2024

🦋 Changeset detected

Latest commit: 4553922

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sit-onyx Minor
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@larsrickert larsrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho the wedge should always be centered without needing to set a property.

@larsrickert larsrickert self-assigned this Jan 2, 2025
Copy link
Collaborator

@larsrickert larsrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubled checked with Jannick, when left/right aligned, the wedge should not be centered and should align like this:
image

We still need to ensure that the wedge looks correct in the info tooltip

@ChristianBusshoff ChristianBusshoff force-pushed the fix/2351-fix-alignment-of-tooltip-component branch from 8283cbe to a2bb99f Compare January 2, 2025 16:01
@larsrickert larsrickert added this pull request to the merge queue Jan 7, 2025
@larsrickert larsrickert removed this pull request from the merge queue due to a manual request Jan 7, 2025
Copy link
Collaborator

@larsrickert larsrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset so this change is released

@ChristianBusshoff ChristianBusshoff added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 15229dd Jan 7, 2025
20 checks passed
@ChristianBusshoff ChristianBusshoff deleted the fix/2351-fix-alignment-of-tooltip-component branch January 7, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants