check for empty instance ID

SchwarzIT · Feb 18, 2023 · 101af9e · 101af9e
1 parent 66bb716
commit 101af9e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/stackit/internal/resources/data-services/instance/actions.go b/stackit/internal/resources/data-services/instance/actions.go
@@ -58,7 +58,12 @@ func (r Resource) Create(ctx context.Context, req resource.CreateRequest, resp *
 
 	// set state
 	plan.ID = types.StringValue(res.JSON202.InstanceID)
+	if plan.ID.ValueString() == "" {
+		resp.Diagnostics.AddError("received an empty instance ID", fmt.Sprintf("invalid instance id: %+v", *res.JSON202))
+		return
+	}
 	resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("id"), res.JSON202.InstanceID)...)
+	resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("project_id"), plan.ProjectID.ValueString())...)
 	if resp.Diagnostics.HasError() {
 		return
 	}

diff --git a/stackit/internal/resources/mongodb-flex/instance/actions.go b/stackit/internal/resources/mongodb-flex/instance/actions.go
@@ -94,6 +94,10 @@ func (r Resource) Create(ctx context.Context, req resource.CreateRequest, resp *
 
 	instanceID := *res.JSON202.ID
 	plan.ID = types.StringValue(instanceID)
+	if instanceID == "" {
+		resp.Diagnostics.AddError("received an empty instance ID", fmt.Sprintf("invalid instance id: %+v", *res.JSON202))
+		return
+	}
 	resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("id"), instanceID)...)
 	resp.Diagnostics.Append(resp.State.SetAttribute(ctx, path.Root("project_id"), plan.ProjectID.ValueString())...)
 	if resp.Diagnostics.HasError() {