Ensure sorted values within nameservers (#250)

Co-authored-by: Robert Hoppe <robert.hoppe@mail.schwarz>

stackit/internal/data-sources/network/actions.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"github.com/google/uuid"
 	"github.com/hashicorp/terraform-plugin-framework/attr"
+	"sort"
 	"strconv"
 	"strings"
 
@@ -49,8 +50,14 @@ func (d DataSource) Read(ctx context.Context, req datasource.ReadRequest, resp *
 	}
 
 	nameservers := make([]attr.Value, 0)
+
 	if network.Nameservers != nil && len(*network.Nameservers) > 0 {
-		for _, ns := range *network.Nameservers {
+		// ensure we have a sorted list, stackit seems to give us
+		// things randomly back which confuses TF
+		nsData := *network.Nameservers
+		sort.Strings(nsData)
+
+		for _, ns := range nsData {
 			nameservers = append(nameservers, types.StringValue(ns))
 		}
 	}

stackit/internal/resources/network/actions.go

@@ -6,6 +6,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"net/http"
 	"reflect"
+	"sort"
 	"strconv"
 	"strings"
 	"time"
@@ -60,6 +61,9 @@ func (r Resource) createNetwork(ctx context.Context, resp *resource.CreateRespon
 		ns = append(ns, nsVal)
 	}
 
+	// ensure we have the Nameservers sorted
+	sort.Strings(ns)
+
 	pl := int(plan.PrefixLengthV4.ValueInt64())
 	name := plan.Name.ValueString()
 
@@ -147,9 +151,14 @@ func (r Resource) Read(ctx context.Context, req resource.ReadRequest, resp *reso
 		}
 	}
 
+	// ensure we have the nameservers sorted
+
 	nameservers := make([]attr.Value, 0)
 	if n.Nameservers != nil && len(*n.Nameservers) > 0 {
-		for _, ns := range *n.Nameservers {
+		nsData := *n.Nameservers
+		sort.Strings(nsData)
+
+		for _, ns := range nsData {
 			nameservers = append(nameservers, types.StringValue(ns))
 		}
 	}