Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51 small adaptations of run script output and plot for scaling experiment #53

Conversation

mknaranja
Copy link
Member

@mknaranja mknaranja commented Oct 9, 2023

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

[ ] The following questions are addressed in the documentation (if need be):

  • Developers (what did you do?, how can it be maintained?)

  • For users (how to use your work?)

  • For admins (how to install and configure your work?)

  • For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

- renamed / cleaned up timers (+ added two timers for applyA)
- General documentation and cleanup
- added gitignore
@mknaranja mknaranja self-assigned this Oct 9, 2023
@mknaranja mknaranja linked an issue Oct 9, 2023 that may be closed by this pull request
4 tasks
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (6a0625f) 35.24% compared to head (4a844de) 35.20%.

Files Patch % Lines
src/polar_multigrid.cpp 4.76% 20 Missing ⚠️
src/multigrid_iter.cpp 37.50% 10 Missing ⚠️
src/gyro.cpp 45.45% 6 Missing ⚠️
src/main.cpp 0.00% 4 Missing ⚠️
src/create_grid_polar.cpp 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   35.24%   35.20%   -0.05%     
==========================================
  Files          86       86              
  Lines        7010     7022      +12     
==========================================
+ Hits         2471     2472       +1     
- Misses       4539     4550      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/create_grid_polar.cpp Outdated Show resolved Hide resolved
src/create_grid_polar.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@carolakruse carolakruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok

@mknaranja mknaranja merged commit 326dcfa into main Dec 12, 2023
3 of 5 checks passed
@mknaranja mknaranja deleted the 51-small-adaptations-of-run-script-output-and-plot-for-scaling-experiment-NEW branch December 12, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small adaptations of run script, output and plot for scaling experiment
3 participants