Update to Julia 1.3.0 #11
Conversation
This updates the Dockerfile to use Julia 1.3.0. Also some changes are made to the mux_server.jl
There was a problem hiding this comment.
Great work @abhishalya . Please test this locally and add some screenshots here and on the Google Code-in site. @amellnik @ChrisRackauckas does this look like it does what you all were looking for?
|
Won't a PR to https://github.com/JuliaDiffEq/DiffEqWebBase.jl/blob/master/src/DiffEqWebBase.jl be required as well? |
|
Looks like it. @amellnik I don't want to add even more things to your plate, but if you have some free time in the next couple of days do you mind adding in som specifics to this task with regard t what needs to be updated? The task is currently a little ambiguous so providing some concrete steps would likely help imo. Also, Thanks for pointing that out @ChrisRackauckas |
@logankilpatrick It won't work, not until the changes are made to the DiffEqWebBase. I tried fixing it, but it seems like there are a lot of changes to be made for it to work. I would need some help there.
@ChrisRackauckas Yeah, it would. I had asked you this over slack, you said that repo needs a month long work. So, I wasn't sure what to do about it. |
|
Also, the task doesn't explicitly mention about any other repos to update. |
|
I'll make a PR to the DiffEqWebBase so that you guys can review, I can make all changes required to that file there. |
|
@kanav99 might be interested in helping get this caught up. |
|
Hey @abhishalya! I can't find the task overview. Can you point that out to me? |
|
https://codein.withgoogle.com/dashboard/task-instances/5439894390833152/ <https://codein.withgoogle.com/dashboard/task-instances/5439894390833152/>
… On Dec 18, 2019, at 10:58 AM, Kanav Gupta ***@***.***> wrote:
Hey @abhishalya <https://github.com/abhishalya>! I can't find the task overview. Can you point that out to me?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#11>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIPN5XV3K7X25CWNZRNRVATQZJJEFANCNFSM4J4LERXQ>.
|
|
I am not a mentor in code in, that's why I think it is not showing up for me. Can you just copy the task description? |
|
|
What’s your email, I will did you as a mentor on this task. |
This updates the Dockerfile to use Julia 1.3.0.
Also some changes are made to the mux_server.jl