-
-
Notifications
You must be signed in to change notification settings - Fork 236
Simple bypass to allow APs to be unitless with unitful connections #4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Unit checking logic is duplicated between Regardless, the logic for the fix is simple
@ChrisRackauckas ready for your review; I believe the test failures are coming from the main branch, please advise if you'd like me to rebase this on an upstream version. |
test/analysis_points.jl
Outdated
| # no units first | ||
| @mtkmodel FirstOrderTest begin | ||
| @components begin | ||
| in = Blocks.Step() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to import MTKStdlib.Blocks for this test. It's currently failing in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I think the submodule is already loaded (twice in fact!), so I just removed the Blocks namespacing. I'll keep an eye on the tests and ping this when it is resolved.
Submodule already loaded.
test/analysis_points.jl
Outdated
|
|
||
| @testset "AnalysisPoint is lowered to `connect`" begin | ||
| @named P = FirstOrder(k = 1, T = 1) | ||
| @named C = Gain(; k = -1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI test failure is pointing here (and other uses of Gain below, not the testsets I added above); Gain is exported by two modules, MTKStdLib.Blocks and...something else? and the ambiguity is causing the error. Unsure why it's throwing after my changes, but let me see if I can specify the module to fix.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Should close #3842, albeit with a solution for a different problem than stated there originally.