Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards nim compat, more examples, and check update #22

Merged
merged 34 commits into from
Oct 14, 2024
Merged

Backwards nim compat, more examples, and check update #22

merged 34 commits into from
Oct 14, 2024

Conversation

lilkeet
Copy link
Contributor

@lilkeet lilkeet commented Oct 13, 2024

this pr:

lilkeet and others added 30 commits August 25, 2024 22:52
@lilkeet
initial commit - all libraries will compile, except for cudnn. Actual…
56c2e91 
… functionality untested.
@lilkeet
compiles, functionality untested. last commit used some files from 8.…
fb71271 
…0 so those had to be updated. also added preprocessor and postprocessor.
@lilkeet
random example working
51a9d2f
@lilkeet
removed pagerank example since nvgraph is no longer in cuda
949b526
@lilkeet
sparse example works
0cf6d60
@lilkeet
fft example works
eb76e29
@lilkeet
refinement of postprocessor and c2nim directives
64820b7
@lilkeet
more discardable procs
50d32ef
@lilkeet
restructure to have both versions 8.0 and 12.5
300307b
@lilkeet
restructure in a way that nimble likes, adapt nimble file to support …
b912b83 
…multiple versions, and fix a bug on postprocessor
@lilkeet
implement documentation generation (index file wont build for 12.5, b…
f90e29c 
…ut will for 8.0?)
@lilkeet
update task description to match implementation
0cbd7ac
@lilkeet
Update README.md
91879be
@lilkeet
Merge branch 'SciNim:master' into master
a162c07
@lilkeet
remove compiled examples (#17 (comment))
3e81788
@lilkeet
better gitignore to avoid more compiled example uploads
c746731
@lilkeet
add back pagerank example (only available for cuda 8.0)
08d5055
@lilkeet
ignore docs
489ee11
@lilkeet
deleted nvgraph from 12.5, was left over from 8.0. (nvgraph no longer…
99cd166 
… in cuda)
@lilkeet
fix pagerank example task
baa490e
@lilkeet
new cublas example (issue #19)
aaba104
@lilkeet
remove path type usage on windows
ebb6f73
@lilkeet
new cusolverDn example (issue #19)
e1dc840
@lilkeet
more consistent interface for version exclusive tasks
e6a69f9
@lilkeet
new cusolverSp example (issue #19)
f923021
@lilkeet
check template -> func, for better stack tracing
a97a1ea
@lilkeet
update required nim version
38f0bef
@lilkeet
1.6.x bugfix, cant inc csize_t
aec143c
@lilkeet
nim 1.6.x bugfix, type inference was not as good
e7377d2
@lilkeet
another type inference bugfix
883a117
Clonkk
Clonkk approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@Clonkk Clonkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean-up !

@Clonkk
Copy link
Member

Clonkk commented Oct 13, 2024

unrelated to tour PR, but we should really setup CI for nimcuda

@Clonkk
Copy link
Member

Clonkk commented Oct 13, 2024

@Vindaar waiting for you to have a look, will merge tomorrow or Tuesday

@lilkeet
Copy link
Contributor Author

lilkeet commented Oct 14, 2024

unrelated to tour PR, but we should really setup CI for nimcuda

agreed, had the same thought as i was makin this pr lol

@Vindaar
Copy link
Member

Vindaar commented Oct 14, 2024

Nice, thanks!

@Vindaar Vindaar merged commit 92b2ffa into SciNim:master Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clonkk Clonkk Clonkk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilkeet @Clonkk @Vindaar