up

[emrgnt-cmplxty]

Important

Add support for collection_ids in document ingestion and updates across API, workflows, and database operations.

• Behavior:
  • Add collection_ids support in ingest_files_app, update_files_app, and ingest_chunks_app in ingestion_router.py.
  • Modify ingestion_workflow.py to handle collection_ids during ingestion and update workflows.
  • Update ingestion_service.py to process collection_ids in ingest_file_ingress and ingest_chunks_ingress.
• Database:
  • Modify kg.py to support collection_ids in entity and triple operations.
• Misc:
  • Fix import order in kg.py and deduplication.py.
  • Remove unused import in kg_workflow.py.

^{This description was created by for dd3a35d. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
yc_demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 4, 2024 9:53pm
yc-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 4, 2024 9:53pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
recommendation_platform	⬜️ Ignored (Inspect)			Nov 4, 2024 9:53pm

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 1adb04e in 1 minute and 19 seconds

More details

• Looked at 262 lines of code in 8 files
• Skipped 0 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. py/core/base/abstractions/__init__.py:23

• Draft comment:
  Duplicate import of CommunityInfo. Remove the original import to clean up the code.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment suggests removing a duplicate import, but the final version of the file only shows one import of CommunityInfo. This indicates that the issue has already been resolved in the diff. The comment is not about a change that needs to be made, as the duplicate import has already been addressed.
  I might be missing some context about why the comment was made, but based on the final file content, it seems the issue is resolved. The comment might have been relevant before the change was made.
  The diff clearly shows the resolution of the duplicate import issue, so the comment is no longer necessary.
  The comment about the duplicate import of CommunityInfo should be deleted because the issue has already been resolved in the diff.

2. py/core/main/api/ingestion_router.py:251

• Draft comment:
  Consider adding a validation to ensure collection_ids length matches files length to prevent potential index errors.
• Reason this comment was not posted:
  Marked as duplicate.

3. py/core/main/api/ingestion_router.py:372

• Draft comment:
  Consider adding a validation to ensure collection_ids length matches chunks length to prevent potential index errors.
• Reason this comment was not posted:
  Marked as duplicate.

4. py/core/main/services/ingestion_service.py:76

• Draft comment:
  Consider adding a validation to ensure collection_ids length matches file_data length to prevent potential index errors.
• Reason this comment was not posted:
  Marked as duplicate.

5. py/core/main/orchestration/hatchet/ingestion_workflow.py:157

• Draft comment:
  This logic for assigning documents to collections based on collection_ids is already present in ingestion_workflow.py. Consider refactoring to avoid duplication.

• Logic for assigning documents to collections (ingestion_workflow.py)

• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_IVzfxTCkBxjLXb9X

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Consider adding a validation to ensure collection_ids length matches files length to prevent potential index errors.

[ellipsis-dev]

Duplicate logic for assigning documents to collections is already present in simple/ingestion_workflow.py. Consider reusing or refactoring the existing code.

• Logic for assigning documents to collections (ingestion_workflow.py)
• Logic for assigning documents to collections (ingestion_workflow.py)

[ellipsis-dev]

👍 Looks good to me! Incremental review on dd3a35d in 49 seconds

More details

• Looked at 327 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. js/sdk/src/r2rClient.ts:494

• Draft comment:
  The collection_ids type has been changed to list[list[UUID]] in the Python code, but here it is still string[]. Consider updating it to string[][] to maintain consistency.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment suggests a type mismatch between the TypeScript and Python code, but the diff does not provide evidence of the Python code. Without seeing the Python code, it's speculative to assume a change is needed. The comment does not provide strong evidence that a change is required in this diff.
  I might be missing the context of the Python code, which could confirm the need for a type change. However, the diff alone does not provide this context, making the comment speculative.
  Without evidence from the diff or the Python code, the comment remains speculative. The rules state to only comment if there is strong evidence of an issue.
  Delete the comment as it is speculative and lacks strong evidence from the diff to support the suggested change.

2. js/sdk/src/r2rClient.ts:683

• Draft comment:
  The collection_ids type has been changed to list[list[UUID]] in the Python code, but here it is still string[]. Consider updating it to string[][] to maintain consistency.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_ADM77dwMMQBCNvIa

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.