Fix Prompt Override #1599
Fix Prompt Override #1599
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2ef8e93 in 39 seconds
More details
- Looked at
88lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/core/providers/llm/litellm.py:57
- Draft comment:
Replaceprintwithlogger.debugfor better logging practices. This also applies to line 71. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_dMytHdjFmyFDAIu2
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 16ec71e in 9 seconds
More details
- Looked at
35lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/core/providers/llm/litellm.py:54
- Draft comment:
The PR description mentions adding print statements for debugging, but they seem to have been removed. Ensure this is intentional and not an oversight. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions adding print statements for debugging, but they are not present in the current diff. This might be an oversight or intentional removal.
Workflow ID: wflow_ayl32eHHHvMbqjCh
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 04ff668 in 19 seconds
More details
- Looked at
41lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_h1kdGNmwjnvMf06f
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
py/core/providers/database/prompt.py
Outdated
|
|
||
| if not prompt_override and not bypass_cache: | ||
| # Cache the template itself if no inputs | ||
| self._prompt_cache.set(prompt_name, template) |
There was a problem hiding this comment.
Consider using cache_key instead of prompt_name when setting the cache to ensure consistency in cache operations.
| self._prompt_cache.set(prompt_name, template) | |
| self._prompt_cache.set(cache_key, template) |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on acb0994 in 15 seconds
More details
- Looked at
55lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/core/providers/database/prompt.py:148
- Draft comment:
Consider raising aValueErrorfor missing inputs whenprompt_overrideis used, to align with the PR description and ensure expected behavior. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment suggests a change in behavior that is not reflected in the code. The current code handles aKeyErrorby returning theprompt_override, which seems intentional. Without the PR description, it's unclear if the behavior should be changed. The comment lacks strong evidence from the code itself to support its suggestion.
I might be missing the context provided by the PR description, which could justify the comment. However, without that context, the comment seems speculative.
The lack of context from the PR description makes it difficult to validate the comment. The code itself does not indicate a need for the suggested change.
Delete the comment as it lacks strong evidence from the code to support the suggested change.
Workflow ID: wflow_4ACAWwMNeiV62pqW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Add debugging print statements and improve prompt handling in
retrieval_router.py,litellm.py, andprompt.py.rag_app()inretrieval_router.pyto logtask_prompt_override._execute_task()and_execute_task_sync()inlitellm.pyto log arguments for completions.get_cached_prompt()inprompt.pyto handleprompt_overrideand input formatting, raisingValueErrorfor missing inputs.Unionimport inprompt.py.This description was created by
for acb0994. It will automatically update as commits are pushed.