Allow boundless coordinates for bilinear and nearest regridders #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage ? 98.39%
=======================================
Files ? 37
Lines ? 4293
Branches ? 0
=======================================
Hits ? 4224
Misses ? 69
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
@SciTools-incubator/esmf-regrid-devs This pull-request is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this pull-request will close automatically in 7 days time. |
github-actions
bot
added
the
Stale: Closure warning
stephenworsley
removed
the
Stale: Closure warning
stephenworsley
force-pushed
the
boundless_coords
branch
from
1ec8a14
to
a48b9a0
Compare
|
|
* main: (29 commits) Bump scitools/workflows from 2024.01.0 to 2024.04.3 (SciTools#356) Bump peter-evans/create-pull-request from 5.0.2 to 6.0.5 (SciTools#355) [pre-commit.ci] pre-commit autoupdate (SciTools#336) Updated environment lockfiles (SciTools#344) Update lockfiles and fix for new esmpy (SciTools#342) Fix for esmpy (SciTools#353) Fix usage of map_blocks (SciTools#338) Revert "Updated environment lockfiles (SciTools#335)" (SciTools#341) Updated environment lockfiles (SciTools#335) Bump actions/cache from 3 to 4 (SciTools#333) Bump actions/upload-artifact from 3 to 4 (SciTools#324) Bump actions/stale from 8.0.0 to 9.0.0 (SciTools#322) fix asv (SciTools#339) [pre-commit.ci] pre-commit autoupdate (SciTools#330) Bump scitools/workflows from 2023.09.0 to 2024.01.0 (SciTools#334) Updated environment lockfiles (SciTools#327) [pre-commit.ci] pre-commit autoupdate (SciTools#328) Updated environment lockfiles (SciTools#304) Add CITATION.cff (SciTools#319) updated for enums (SciTools#293) ... # Conflicts: # esmf_regrid/schemes.py
|
It would be great if this could get reviewed and merged for reasons explained in #368 (comment). Would it help to speed this up if I did a review? |
12 tasks
|
@stephenworsley please update + I will progress ! |
9 tasks
* main: Bump scitools/workflows from 2024.06.0 to 2024.06.5 (SciTools#377) Fix typo (SciTools#371) Bump scitools/workflows from 2024.04.3 to 2024.06.0 (SciTools#365) Update to v0.11.dev0. (SciTools#363) Update to v0.10.0 (SciTools#362) Extend regridder saving/loading to all regridders (SciTools#357) Ensure dtype is preserved after regridding (SciTools#239) Move benchmark code from nox to bm_runner (SciTools#361) # Conflicts: # esmf_regrid/schemes.py
stephenworsley
force-pushed
the
boundless_coords
branch
from
8f4b24c
to
1c12a90
Compare
* main: Fix unmasked connectivity bug (SciTools#385) # Conflicts: # esmf_regrid/schemes.py
* main: Adapt to changes in iris structure (SciTools#387)
HGWright
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Looks great @stephenworsley, thanks for this change! Been in the works for a while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bilinear and nearest methods do not require coordinate bounds in order for ESMF to do regridding. This PR makes it so that grids without bound information are regridable via these methods.