Merged
Conversation
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6808 +/- ##
=======================================
Coverage 90.39% 90.39%
=======================================
Files 91 91
Lines 24761 24761
Branches 4639 4639
=======================================
Hits 22382 22382
Misses 1608 1608
Partials 771 771 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ukmo-ccbunney
approved these changes
Nov 20, 2025
Contributor
|
Just the template to action here, then we're good to merge. 👍🏼 |
Member
Author
|
Member
Author
|
@ukmo-ccbunney For extra credit ... also raised issue #6809 😉 |
Contributor
|
Nice! All good to go. 🚀 |
Template update addresses in referenced PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Playing forward some quality-of-life improvements and fixes to
ci-linkcheck.yml, namely:argsandlabelsby using multi-line inputconcurrencycontrolsactions/checkoutpersisted credentialsif:syntax - GHAs use expressions inside${{ ... }}for evaluation, otherwise the condition is treated as text, which can result in incorrect behaviourfromJSONfor readability. The flip would be to adopt... != '0'instead.fromJSONto coerceexit_codefor integer comparisonAs an aside, I'd recommend that
irisshould adopt zizmor compliance for static analysis of its GHAs 💯Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: