Skip to content

gha: fix lychee#6808

Merged
ukmo-ccbunney merged 1 commit intoSciTools:mainfrom
bjlittle:lychee
Nov 20, 2025
Merged

gha: fix lychee#6808
ukmo-ccbunney merged 1 commit intoSciTools:mainfrom
bjlittle:lychee

Conversation

@bjlittle
Copy link
Member

@bjlittle bjlittle commented Nov 20, 2025

🚀 Pull Request

Description

Playing forward some quality-of-life improvements and fixes to ci-linkcheck.yml, namely:

  1. Improve readabilty for args and labels by using multi-line input
  2. Group and rationalise multiple job runs with concurrency controls
  3. Adopt artipacked pattern remediation as zizmor recommended best practice regarding actions/checkout persisted credentials
  4. Fix incorrect if: syntax - GHAs use expressions inside ${{ ... }} for evaluation, otherwise the condition is treated as text, which can result in incorrect behaviour
    • Adopted fromJSON for readability. The flip would be to adopt ... != '0' instead.
  5. Use fromJSON to coerce exit_code for integer comparison

As an aside, I'd recommend that iris should adopt zizmor compliance for static analysis of its GHAs 💯


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

scitools-ci[bot]
scitools-ci bot previously requested changes Nov 20, 2025
Copy link
Contributor

@scitools-ci scitools-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (9bd0970) to head (5886042).
⚠️ Report is 69 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6808   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          91       91           
  Lines       24761    24761           
  Branches     4639     4639           
=======================================
  Hits        22382    22382           
  Misses       1608     1608           
  Partials      771      771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks very sensible to me. Good catch on the plain text if conditions. 👍🏼
LGTM.

@ukmo-ccbunney
Copy link
Contributor

Just the template to action here, then we're good to merge. 👍🏼

@bjlittle
Copy link
Member Author

Just the template to action here, then we're good to merge. 👍🏼

@ukmo-ccbunney see SciTools/.github#231

@bjlittle
Copy link
Member Author

bjlittle commented Nov 20, 2025

@ukmo-ccbunney For extra credit ... also raised issue #6809 😉

@ukmo-ccbunney
Copy link
Contributor

Nice! All good to go. 🚀

@ukmo-ccbunney ukmo-ccbunney dismissed scitools-ci[bot]’s stale review November 20, 2025 22:42

Template update addresses in referenced PR

@ukmo-ccbunney ukmo-ccbunney merged commit e68ca2f into SciTools:main Nov 20, 2025
24 checks passed
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants