Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFD-194: Fix error on app startup #129

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

mgriffin-scottlogic
Copy link
Collaborator

SFD-194 Jira ticket

Description of Change

Ensure internal apex chart is ready before attempting to update its options.

There is a short period of time where the ng-apexchart ChartComponent has been created but it hasn't finished setting up the ApexChart element it's wrapping. Potentially a bug in their code but the chartReady event suggests it's something to be expected.

Checklist

  • tests are updated or added

@sdun-scottlogic
Copy link
Contributor

Tested & Approved - SD.

@mgriffin-scottlogic mgriffin-scottlogic merged commit e414322 into main Sep 10, 2024
3 checks passed
@mgriffin-scottlogic mgriffin-scottlogic deleted the sfd-194-startup-error branch September 10, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants