Ruff E through P #45
Merged
Ruff E through P #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandophahita
commented
Feb 3, 2024
| "EM", # flake8-errmsg | ||
| "ERA", # eradicate | ||
| "F", # Pyflakes | ||
| "FA", # flake8-future-annotations | ||
| # "FBT", # flake8-boolean-trap |
There was a problem hiding this comment.
purposefully skipping FBT for this PR. Will be addressed in it's own at the end.
perrygoy
approved these changes
Feb 7, 2024
| ruff = {version = "*", optional = true} | ||
| ruff = {version = ">=0.2.0", optional = true} |
There was a problem hiding this comment.
The new rule changes in the pyproject.toml occurred at that version.
[tool.ruff.lint.***]
Comment on lines
-171
to
+173
| assert annotation == Optional[TargetingError] | ||
| assert annotation == "Optional[TargetingError]" |
There was a problem hiding this comment.
Interesting, i'm assuming this is from the from __future__ import annotations change?
There was a problem hiding this comment.
Yep. All annotations are strings when using future.
Comment on lines
+92
to
+93
| with pytest.raises(ValueError, match="locator tuple length should be 2"): | ||
| Target("test").located((By.ID, "foo", "baz")) # type: ignore[arg-type] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.