Ruff q-z #46
Merged
Ruff q-z #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrygoy
approved these changes
Feb 7, 2024
| [mypy-screenpy.*] | ||
| [mypy-screenpy_selenium.*] |
| if TYPE_CHECKING: | ||
| from screenpy.actor import Actor | ||
|
|
||
| from ..target import Target | ||
|
|
||
| SelfClear = TypeVar("SelfClear", bound="Clear") |
There was a problem hiding this comment.
You can actually move these TypeVar declarations into the TYPE_CHECKING block, too, if you want. Then you can also import the TypeVar in there.
I don't have strong opinions on it, but i do like that all the type checking stuff is contained within that block that way.
There was a problem hiding this comment.
I'm about to yank all of those typevars out after the ruff changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.