Actionchain speedup #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrygoy
approved these changes
Mar 7, 2024
| @@ -0,0 +1,55 @@ | |||
| ======== | |||
| Settings | |||
There was a problem hiding this comment.
Do we want to also link to ScreenPy's settings here?
Comment on lines
+7
to
+20
| class ScreenPySeleniumSettings(ScreenPySettings): | ||
| """Settings for the ScreenPySelenium. | ||
|
|
||
| To change these settings using environment variables, use the prefix | ||
| ``SCREENPY_SELENIUM_``, like so:: | ||
|
|
||
| SCREENPY_SELENIUM_CHAIN_DURATION=50 # sets the actionchain duration to 50ms | ||
| """ | ||
|
|
||
| _tool_path = "screenpy.selenium" | ||
| model_config = SettingsConfigDict(env_prefix="SCREENPY_SELENIUM_") | ||
|
|
||
| CHAIN_DURATION: int = 10 | ||
| """Default duration of ActionChains in milleseconds""" |
There was a problem hiding this comment.
Isn't it nice how easy this is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So apparently ActionChains have an argument called
durationthat affect how long selenium lingers on the chain even if it finishes immediately. This update makes it possible for users to adjust the duration globally.