Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yarn-sdks): Add hook to generate Yarn SDKs #311

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

Kurt-von-Laven
Copy link
Contributor

Ensure Yarn SDKs remain up-to-date. Run Prettier on VSCode settings within the same hook to prevent formatting conflicts with MegaLinter, which also runs Prettier. Define the hook as a script since system hooks don't support running multiple commands.

@Kurt-von-Laven Kurt-von-Laven self-assigned this Sep 20, 2023
Copy link
Contributor

@mwarres mwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice change!

Ensure Yarn SDKs remain up-to-date. Run Prettier on VSCode settings
within the same hook to prevent formatting conflicts with MegaLinter,
which also runs Prettier. Define the hook as a script since system hooks
don't support running multiple commands.
@Kurt-von-Laven
Copy link
Contributor Author

Thank you! I did a pure rebase on the build fix, so no need for another round of review.

@Kurt-von-Laven Kurt-von-Laven merged commit 16597ea into main Sep 20, 2023
@Kurt-von-Laven Kurt-von-Laven deleted the yarn-sdks branch September 20, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants