240619_03_박서윤 #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. YukymTimeModel이 주어진 코드만 봤을때는 어떤 의미를 가지는지 알 수 없어서 삭제해버림.. 3. getTyA()에서 월 값은 1~12 외의 다른 값이 올 때는 경오 7국 으로 반환하는 월 유효성검사. 4. getTyB()에서는 시간 값이 항상 0~24를 보장하므로 유효성 검사 필요없다고 판단. 5. 사실 이렇게 맘대로 바꿔도 되는진 모르겠지만 그냥 해봄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수정내용은 커밋으로 남겼습니다
리팩하고싶었지만 그건 다음기회에... ˊᵕˋ