fix: use net module instead of exe os command #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJ-Fan
force-pushed
the
fix/remove-os-dependent-for-ip-detection
branch
from
83edc63
to
25d3346
Compare
This removes the os dependency on host ip detection This method dials the public dns to see the host IP. If the host is in a complete private network, it might fail. In this case, the user could use the input argument to specify host IP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the os dependency on host ip detection
This method dials the public dns to see the host IP.
If the host is in a complete private network, it might fail.
In this case, the user could use the input argument to specify host IP