Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle <!-- <script </script in JavaScript #1429

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

marschall
Copy link
Contributor

This is my try a fixing #1379.

If we check the release version of 4.12.1.3 Restrictions for contents of script elements we need to handle <!--, <script and </script.

I tried to do meaningful commits.

Fixes #1379

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.09%. Comparing base (44e5bb7) to head (66a0987).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
- Coverage   49.10%   49.09%   -0.02%     
==========================================
  Files        9143     9150       +7     
  Lines       80545    80633      +88     
==========================================
+ Hits        39553    39584      +31     
- Misses      40992    41049      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@marschall marschall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanatory comments for reviewers.

Copy link
Member

@jbrichau jbrichau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having addressed this. It was pending on my stack since a while ;-)
Just a minor method revert to change and this is good to go for me!

@jbrichau
Copy link
Member

@marschall I noticed you made the change but did not trigger a new review. I assume this PR is ready? If it is, I will happily merge it.

@marschall
Copy link
Contributor Author

I assume this PR is ready?

Yes, it is.

If it is, I will happily merge it.

That would be great.

@marschall marschall merged commit 597e6d0 into SeasideSt:master Jul 16, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested script tags are not properly escaped
2 participants