Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html deprecations #1434

Merged
merged 9 commits into from
Jul 13, 2024
Merged

Fix html deprecations #1434

merged 9 commits into from
Jul 13, 2024

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Jul 13, 2024

Removes the use of tags and attributes currently deprecated (or non-functioning) in HTML5 from the Seaside tests and examples.

Also fix the wrong deprecation of:

  • the th.scope attribute (it was only deprecated for td tags).
  • the charset attribute on meta tags

Fixes #1418

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.04%. Comparing base (d90609c) to head (ad52bec).

Files Patch % Lines
...Test.class/instance/renderInline.factor.key.on..st 0.00% 3 Missing ⚠️
...sFunctionalTest.class/instance/renderContentOn..st 0.00% 2 Missing ⚠️
...eFunctionalTest.class/instance/renderAnchorsOn..st 0.00% 1 Missing ⚠️
....class/instance/renderCellForDate.row.index.on..st 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   49.09%   49.04%   -0.06%     
==========================================
  Files        9144     9143       -1     
  Lines       80565    80552      -13     
==========================================
- Hits        39553    39506      -47     
- Misses      41012    41046      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau merged commit 9ae0073 into master Jul 13, 2024
18 of 24 checks passed
@jbrichau jbrichau deleted the fix-html-deprecations branch July 13, 2024 19:18
Copy link
Contributor

@marschall marschall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated messages in functional tests
2 participants