Issue planetteamspeak#186: Improve Host::permissionTree() function (p…

…lanetteamspeak#189)

* Fetch permission list only once

This reduces the amount of executed `permissionlist` ServerQuery
commands, which also should improve the overall performance of
this function.

* Issue planetteamspeak#186: Fix offset error

Avoids the error `Trying to access array offset on value of type int`
by ensuring first, that the array has the required structure.

---------

Co-authored-by: sebastian_kraetzig <sebastian.kraetzig@4g-server.eu>

src/Node/Host.php

@@ -641,6 +641,8 @@ public function permissionEnds(): array
      */
     public function permissionTree(): array
     {
+        $permissionList = $this->permissionList();
+
         $permtree = [];
 
         foreach ($this->permissionCats() as $val) {
@@ -659,7 +661,10 @@ public function permissionTree(): array
                 $permtree[$val]["permcatname"] = $permtree[$val]["permcatname"]->section("/", 1)->trim();
             }
 
-            foreach ($this->permissionList() as $permission) {
+            foreach ($permissionList as $permission) {
+                if ((! array_key_exists("permid", $permission)) or (! array_key_exists("permcatid", $permission["permid"]))) {
+                    continue;
+                }
                 if ($permission["permid"]["permcatid"] == $val) {
                     $permtree[$val]["permcatcount"]++;
                 }