Skip to content

Conversation

@HexyWitch
Copy link
Contributor

@HexyWitch HexyWitch commented Sep 9, 2025

Fixes #238

@HexyWitch HexyWitch requested a review from LPGhatguy as a code owner September 9, 2025 20:23
@HexyWitch HexyWitch changed the title We have anymap at home (#235 We have anymap at home (#235) Sep 9, 2025
@HexyWitch HexyWitch changed the title We have anymap at home (#235) We have anymap at home Sep 9, 2025
@LPGhatguy
Copy link
Member

I know we talked about the originating problem being something related to wasm; did you ever figure out what was going on there?

I admit I've been putting off this PR because I'm a little uncertain about reimplementing part of a crate to solve a problem like that.

@HexyWitch
Copy link
Contributor Author

Oops sorry i linked the wrong issue. This is the right one #238

Copy link
Contributor

@sanbox-irl sanbox-irl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge this -- it simply replaces a part of the API with an even smaller API that is trivial to maintain. That's just a win IMO!

@LPGhatguy
Copy link
Member

We should merge this -- it simply replaces a part of the API with an even smaller API that is trivial to maintain. That's just a win IMO!

I don't think this is a slam dunk for me. There are a couple tricks that anymap uses that this PR doesn't replicate that I like but also don't have any interest in maintaining.

This PR makes sense to me if both:

  1. anymap cannot work on wasm for whatever reason
  2. there is no easy fix to anymap or an alternative crate

@sanbox-irl
Copy link
Contributor

but lucien, it would mean that i'd have one less anymap in my tree. think of the advantages!

@HexyWitch
Copy link
Contributor Author

To be clear I don't think this should be merged as is!

The PR is a sharp elbow in your side and also a place where you can tell me what should be done instead!

@sanbox-irl
Copy link
Contributor

There are a couple tricks that anymap uses that this PR doesn't replicate that I like but > also don't have any interest in maintaining.

What are those tricks? Just based on the PR, it doesn't feel like we actually use any thing not shown here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anymap is broken on wasm

3 participants