More cosmic text integration #251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
LPGhatguy
reviewed
Nov 18, 2025
Member
LPGhatguy
left a comment
LPGhatguy
left a comment
There was a problem hiding this comment.
Not quite a real review yet, just one note
msparkles
force-pushed
the
more-cosmic-text
branch
from
2116e8a to
6af9ed1
Compare
msparkles
force-pushed
the
more-cosmic-text
branch
4 times, most recently
from
6c6cc05 to
675a66b
Compare
msparkles
force-pushed
the
more-cosmic-text
branch
from
675a66b to
cf37e0d
Compare
Contributor
Author
|
today in "text is hard": this caused an obscure bug that took me a really long while to debug and i only really fixed it by accident of "this is logically incorrect" and fixing it and not even realising that i fixed the bug i was having |
msparkles
force-pushed
the
more-cosmic-text
branch
2 times, most recently
from
827d1bd to
b9b06ae
Compare
msparkles
force-pushed
the
more-cosmic-text
branch
from
b9b06ae to
572b0c3
Compare
msparkles
force-pushed
the
more-cosmic-text
branch
9 times, most recently
from
fc8c139 to
6f4c946
Compare
Contributor
Author
|
Alright unless we missed something with the font stuff this should be mostly stable and ready for review? We'd still like some multiplatform testing for the textbox though |
msparkles
force-pushed
the
more-cosmic-text
branch
4 times, most recently
from
17281c3 to
1d000bb
Compare
msparkles
force-pushed
the
more-cosmic-text
branch
2 times, most recently
from
ee7f6ec to
17cd435
Compare
…xamples, fix most alignment issues, some performance fixes
- update cosmic-text to 0.17
- work around scrolling issues with cosmic text
- fix textbox mouse dragging handling
- fix textbox flickering
- make RenderText calculate widest line of the entire text, and not just what's visible
- slightly improve RenderText performance by reducing unnecessary work
- cache widest line until text changed
- cache size until text changed
- don't prune layouting/shaping results until text changed
- fix RTL text rendering
- fix TextAtlas texture format with Color glyphs (Rgba8SrgbPremultiplied -> Rgba8Srgb)
- fix TextAtlas erroneously and repeatedly re-rendering glyphs when Color glyphs are requested
- cleanup text_renderer.rs a lot
- add mechanism to clear TextAtlas state when fonts change
- change default line height to 1.2
- mark blit as inline
- add more checks for textbox's active state
- add active field to TextBoxResponse
- separate out logic for calculating the max line width into a function
- add full Ime support with text_cursor in input_state and integrate it with winit and SDL
- improve text examples, make them use system fonts, add ability to use system fonts
- fix most alignment issues, add min_width and inline props to control alignment behavior
- make yakui manage its own font selection instead of relying on cosmic-text's mechanisms
also, a bunch of fixes with cursor and selection:
- cursor renders correctly now (there are no longer cases where the cursor either disappears or renders on the wrong line due to cursor affinity)
- ctrl+a works correctly now
- tapping left after ctrl+a works correctly now (puts cursor to start of selection)
- shifting while tapping up/down works correctly now
- selecting whole word works correctly now
- deselecting whole word works correctly now
- deselecting characters works correctly now
- selecting while cursor is inbetween a word works correctly now
msparkles
force-pushed
the
more-cosmic-text
branch
from
17cd435 to
a39a09a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 🚀 🦀
read the commit messages for changes please we're so tired after everything 💯
Also, it would be nice if we can get Mac & Windows users to test both the winit end and the SDL3 end. It would be really nice if we can get more people trying to use an input method on the
textboxexample. Preferably in HiDPI as well.There are a few issues with the code that are mostly just cosmic-text's own issues. No idea when they'd get fixed though.