Skip to content

More builders #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
msparkles wants to merge 6 commits into
base: main
Choose a base branch
from
Open

More builders #263

msparkles wants to merge 6 commits into from

Conversation

@msparkles
Copy link
Contributor

@msparkles msparkles commented Jan 11, 2026

we like building here

Ralith
Ralith reviewed Jan 11, 2026
View reviewed changes
@msparkles
make auto_builders more tolerant of trailing commas, or the lack thereof
1963c3c 
previously, if the struct fed into auto_builders only has one field, and doesn't have a trailing comma, the macro would fail. we don't want that, we'd like formatting to not affect whether or not our code builds.
@msparkles
make auto_builders take a generic type T: Into<$type> instead
b5eca49 
there are some manually implemented builder methods that are made because of a desire to be generic. let's just make it generic by default and let the compiler do its thing.
Ralith
Ralith reviewed Jan 13, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ralith Ralith Ralith left review comments

@kanerogers kanerogers Awaiting requested review from kanerogers kanerogers is a code owner

@LPGhatguy LPGhatguy Awaiting requested review from LPGhatguy LPGhatguy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msparkles @Ralith @LPGhatguy