OPENIG-8693 Apply latest IDM Service configuration #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "args": { | ||
| "routeArgObjApiClient": "apiClient", | ||
| "routeArgIdmBaseUri": "https://&{identity.platform.fqdn}" | ||
| "routeArgIdmService": "${heap[IdmService]}", |
Contributor
There was a problem hiding this comment.
The script seems to use idmService arg name?
That would be better, don't see why we need the routeArg... prefixes really.
| return response | ||
|
|
||
| }).then(response -> { return response }) | ||
| idmService.send(context, apiClientRequest) |
Contributor
There was a problem hiding this comment.
This also seems a better fit (the intention) to use idmService here (not http), isn't it?
guillaumelamirand
force-pushed
the
OPENIG-8693-simplify-idm-service-configuration
branch
from
9dac1c5 to
e3c254e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest change on IdmService configuration to make it easier