Skip to content

[Snyk] Security upgrade urllib3 from 1.25.11 to 2.6.3 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
franksec42 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade urllib3 from 1.25.11 to 2.6.3 #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,4 @@ zipp==0.6.0
requests==2.23.0
toml==0.10.2
PyYAML==5.3.1
urllib3>=2.6.3 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

@gemini-code-assist gemini-code-assist bot Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change introduces a dependency conflict that will break the installation process. The requests package, version 2.23.0 (as specified on line 55), requires urllib3<1.26.

The proposed change to urllib3>=2.6.3 is incompatible with this constraint because urllib3 v2.x contains breaking changes. Support for urllib3 v2.x was added in requests v2.30.0.

This PR as-is will cause pip to fail during installation. To fix this, you must also upgrade requests. Here are two options:

  1. Upgrade requests to a version that supports a patched urllib3 1.x version (e.g., requests>=2.26.0 allows urllib3<1.27). You could then pin urllib3 to a version like 1.26.18.
  2. Upgrade requests to a version that supports urllib3 2.x (e.g., requests>=2.30.0).

This automated PR is incomplete and will not work. The requests dependency must be updated to correctly resolve the vulnerability.

Loading