Skip to content

Commit

Permalink
Fix session cookie not saving for localhost in Safari & FireFox (#3301)
Browse files Browse the repository at this point in the history
  • Loading branch information
CarsonF authored Oct 2, 2024
1 parent b3fa3ea commit f292865
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/core/config/config.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,12 @@ export const makeConfig = (env: EnvironmentService) =>
httpOnly: true,
// All paths, not just the current one
path: '/',
// Require HTTPS (required for SameSite) (ignored for localhost)
secure: true,
// Allow 3rd party (other domains)
sameSite: 'none',
...(!isDev && {
// Require HTTPS (required for SameSite)
secure: true,
// Allow 3rd party (other domains)
sameSite: 'none',
}),
};
})();

Expand Down

0 comments on commit f292865

Please sign in to comment.