forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 2
Move LSTGeometry repo into ESProducer and standalone binary #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ariostas
wants to merge
95
commits into
master
Choose a base branch
from
ariostas/lst_geometry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
1739720
Started implementing code in C++
ariostas 8878167
Finished with corners
ariostas bd63e47
Added IO
ariostas b695081
Format
ariostas a121d44
Added centroid methods
ariostas 7c75d07
Added orientation methods
ariostas 662f7d2
Started implementing pixel maps
ariostas 38b8735
Finished with pixel maps
ariostas 3b2e3a2
Started implementing module maps
ariostas 6b39965
Some progress on module maps
ariostas fe7c81d
Switched namespace to lstgeometry
ariostas 17b90b2
A couple of fixes
ariostas 0256927
Finished module maps
ariostas f5a44ef
Added standalone binary
ariostas 2038d28
Added a couple of outputs
ariostas 61e33ea
Write module maps
ariostas 0d50566
Some progress, but need to switch to gcc13
ariostas 33ec364
Write pixel maps
ariostas 074e368
Fixed pixel maps
ariostas 03b24e6
Simplify pixel maps creation
ariostas b78a982
Fixed straight line connections
ariostas d3dba40
Fixed curved line connections
ariostas 4a0ef90
Format code
ariostas 218dffd
A bit of cleanup
ariostas fedf5a3
Added eta-phi binning
ariostas ca59512
format
ariostas 9ff260d
Added cmssw scaffoling
ariostas cf2ed78
Some progress getting required data
ariostas 386cf93
Removed unused struct members
ariostas fcc5aa9
Everything mostly matches up now, but need to clean up
ariostas eecb9bc
Switched from mm to cm
ariostas 2a0858f
All CMSSW inputs work
ariostas 78b86ca
Added LSTGeometry struct and moved constuctor to common place
ariostas 51ba97b
Finished dump test
ariostas 9acfea6
A few fixes
ariostas a4663d8
Fixed orientations
ariostas 0888935
Adapted the LST ES producer
ariostas 7821502
Fixed python file
ariostas 61369ba
Fixed typo
ariostas c56a823
Make pt cutoff selectable
ariostas 94368d4
A bit of cleanup
ariostas 74f2e9e
Fix typo
ariostas 283fd59
Fix bug from original code
ariostas 74cd74d
Fix typo
ariostas 5dafbad
Fix typo
ariostas 6ac6e04
Fixed type issue
ariostas 5c395e8
Remove kVerticalModuleSlope
ariostas 75e1af8
Minor cleanup
ariostas cc7baf9
Add ptCut parameter to test
ariostas 0053ffc
Add binary output option
ariostas 2076b5b
Didn't actually need corner coordinates
ariostas f2236b3
Fixed sign of some angles
ariostas 72cb6bd
Leave a note on how to match the csv files
ariostas 7540ca0
Figured out the sign
ariostas 6983407
Added cli options to test
ariostas 180bb05
Tweak cmssw config
ariostas 1c3a72e
Switch to numerical parameters
ariostas 40f8659
Minor cleanup
ariostas 5bf6f99
Added help option
ariostas a328d7c
Improve explanation of procedure
ariostas 6deaf04
Rename ES functions for different payloads
ariostas cc91d49
Moved things to a new LSTGeometry package
ariostas 8c42aea
Renamed Centroid to SensorCentroid
ariostas 413cb29
Fixed python config
ariostas b3a405f
Removed code for standalone generation from csv files
ariostas 91fc203
Add newline back
ariostas 154533b
Minor tweaks
ariostas ae28cf9
Fixed test
ariostas 99ad8e1
Started removing Module.h
ariostas b76a391
Started moving implementations to cc files
ariostas 1b48eb3
Refactored Sensor
ariostas 5b61e02
Removed Module.h
ariostas a62d0a6
Useful renamings
ariostas 90c2e79
Temporary fix for segfault
ariostas 25385e7
Moved more implementations to cc files
ariostas 5e10176
GeomDetEnumerators::isBarrel doesn't work
ariostas 81ef945
Missed namespace
ariostas 43e8b03
Minor tweaks
ariostas f76e1f7
Fixed side, isLower and isStrip
ariostas a4916ad
Fixed slopes
ariostas a4999bf
Fixed subdet for pixelmap
ariostas 460e347
Tweaked constants and types
ariostas 9a86f17
Fixed pixel map
ariostas 2a6791d
Refactored slopes
ariostas 0ff7265
Find corners with CMSSW functionality
ariostas 17c4e6d
Cleanup
ariostas b9b0db9
Tried to fix producer labels
ariostas fda1b75
Fixed typo
ariostas 0bef46d
Started addressing review comments
ariostas a3b60a0
Addressed some more review issues
ariostas 6b154d6
Removed Module struct
ariostas 373f78d
Revert to previous value of kB
ariostas 4c0f52e
Back to 3.8, but fixed sign in module maps
ariostas 2044970
Fixed eta computation and phi binning
ariostas 9f84e80
Moved Helix out of standalone
ariostas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should still have a possibility to have multiple payloads in the same job with different thresholds.