Skip to content

Update HighPurity ID to be a pass-through for displaced tracks#205

Closed
VourMa wants to merge 2 commits intomasterfrom
trackClassifierForDispTrks
Closed

Update HighPurity ID to be a pass-through for displaced tracks#205
VourMa wants to merge 2 commits intomasterfrom
trackClassifierForDispTrks

Conversation

@VourMa
Copy link
Collaborator

@VourMa VourMa commented Oct 10, 2025

As per title. The T5 build track collections have been replaced in the configuration by their equivalent high purity track collections, so the configuration is fully working.

There are 3 procModifier combinations that are affected by this change:

  1. trackingLST (all plots)
image
  1. singleIterPatatrack,trackingLST (all plots)
image
  1. trackingLST,seedingLST (all plots)
image

I am not sure I fully understand the small differences, given that both tries were on CPU, but I would be OK to take them, since the overall picture remains unchanged.

@VourMa
Copy link
Collaborator Author

VourMa commented Oct 13, 2025

/run all
/run gpu-all

@github-actions
Copy link

The PR was built and ran successfully in standalone mode on GPU. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
[target branch]
   avg     15.1      0.4      0.4      0.5      0.6      0.3      0.6      0.3      0.9      0.0      19.2       3.8+/-  0.8      19.2   explicit[s=1]
   avg      0.9      0.6      0.6      0.7      0.8      0.3      1.0      0.4      1.2      0.0       6.6       5.4+/-  1.1       3.3   explicit[s=2]
   avg      1.4      0.9      1.0      1.2      1.3      0.4      1.5      0.7      1.9      0.0      10.3       8.5+/-  1.8       2.6   explicit[s=4]
   avg      2.1      1.3      1.5      1.7      1.8      0.6      2.1      0.9      2.6      0.0      14.5      11.9+/-  2.4       2.5   explicit[s=6]
   avg      2.8      1.7      2.0      2.3      2.5      0.8      2.8      1.2      3.2      0.0      19.3      15.8+/-  3.8       5.0   explicit[s=8]
[this PR]
   avg     15.1      0.4      0.4      0.5      0.6      0.3      0.6      0.3      0.9      0.0      19.2       3.8+/-  0.8      19.3   explicit[s=1]
   avg      0.8      0.5      0.6      0.7      0.8      0.3      1.0      0.5      1.2      0.0       6.5       5.3+/-  1.1       3.3   explicit[s=2]
   avg      1.4      0.8      1.0      1.2      1.3      0.4      1.6      0.7      2.0      0.0      10.4       8.5+/-  1.9       2.6   explicit[s=4]
   avg      2.2      1.3      1.5      1.7      1.8      0.6      2.1      0.9      2.6      0.0      14.7      11.9+/-  2.7       2.5   explicit[s=6]
   avg      2.7      1.6      1.9      2.3      2.5      0.7      2.8      1.2      3.3      0.0      19.2      15.7+/-  3.9       2.5   explicit[s=8]

@github-actions
Copy link

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     29.3    371.5    273.6    124.0     47.0    686.9    124.0    129.1    168.4      1.5    1955.2    1239.0+/- 288.4     605.3   explicit[s=4] (target branch)
   avg     28.6    367.8    272.0    122.1     46.4    687.7    122.2    128.1    167.2      1.4    1943.4    1227.1+/- 290.6     606.5   explicit[s=4] (this PR)

@github-actions
Copy link

The PR was built and ran successfully with CMSSW on GPU. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@github-actions
Copy link

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@slava77
Copy link

slava77 commented Oct 21, 2025

should this be closed as superseded by #208 ?

@VourMa
Copy link
Collaborator Author

VourMa commented Oct 21, 2025

should this be closed as superseded by #208 ?

I am waiting to see when/how #208 converges, so I am keeping this one open for now. But yes, it can be ignored for now.

@VourMa
Copy link
Collaborator Author

VourMa commented Nov 12, 2025

Superseded by #208

@VourMa VourMa closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants