Closed
Conversation
Author
|
/run all |
|
The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.
The full set of validation and comparison plots can be found here. Here is a timing comparison: |
Author
|
before and after: So, this confirms the guess that the pt3dnn demotes pLS with larger errors. Retraining would be an option, but it's a complication on how to handle the model inputs: either something like in #143 or still compiled but a different function/inference call |
|
The PR was built and ran successfully with CMSSW. Here are some plots. OOTB All Tracks
The full set of validation and comparison plots can be found here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









I'm following a few failures using pLS with OT hits that happen in the pT3 DNN.
(on decent stats) comparing pLS fits using pixel/IT hits only vs the OT-extended: fitter pt errors x1.5 but rec-sim RMS goes down by /2.
With only two examples of the pt3dnn failures, it's unclear where the origins are: did the DNN learn some pt,eta-dependent biases to have good T3-pLS match or does it demote pLS with larger errors.
If the DNN demotes large error pLS, this test should show an efficiency drop in pTx reco.