fix: silent crashes & add ability to compare other players by tag #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seizoxu
approved these changes
Jan 17, 2024
Comment on lines
+35
to
+40
| if (args.length == 2) { | ||
| idStr = args[1].subSequence(2, args[1].length()-1).toString(); | ||
| } else { | ||
| idStr = event.getAuthor().getId(); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is an older way of checking arguments, especially for pings. I think the newer for-cmd-switch statement in a parseArguments() method would be better for scalability, but it's fine for now, since I can't think of any other arguments we'd add to \c. Still good to keep in mind for later uses.
Also, there's a specific method to get a mentioned member within a message, event.getMessage().getMentionedMembers().get(0).getId(), which is better than manually checking the String, but the functionality is effectively the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.