Add config to fail if search targets too many splits#6
Closed
rdettai-sk wants to merge 16 commits intoSekoiaLab:mainfrom
Closed
Add config to fail if search targets too many splits#6rdettai-sk wants to merge 16 commits intoSekoiaLab:mainfrom
rdettai-sk wants to merge 16 commits intoSekoiaLab:mainfrom
Conversation
Bumps the github-actions group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [actions/checkout](https://github.com/actions/checkout) | `5.0.0` | `5.0.1` | | [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) | `6d653acede28d24f02e3cd41383119e8b1b35921` | `0f44b27771c32bda9f458f75a1e241b09791b331` | | [taiki-e/install-action](https://github.com/taiki-e/install-action) | `2.62.40` | `2.62.52` | | [sarisia/actions-status-discord](https://github.com/sarisia/actions-status-discord) | `1.15.4` | `1.15.5` | | [actions/dependency-review-action](https://github.com/actions/dependency-review-action) | `45529485b5eb76184ced07362d2331fd9d26f03f` | `125b99508212ce1cc3076ad60f6bd63bf6d88a66` | | [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) | `3.6.0` | `3.7.0` | | [docker/metadata-action](https://github.com/docker/metadata-action) | `5.8.0` | `5.9.0` | | [github/codeql-action](https://github.com/github/codeql-action) | `4.31.0` | `4.31.3` | Updates `actions/checkout` from 5.0.0 to 5.0.1 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@08c6903...93cb6ef) Updates `dtolnay/rust-toolchain` from 6d653acede28d24f02e3cd41383119e8b1b35921 to 0f44b27771c32bda9f458f75a1e241b09791b331 - [Release notes](https://github.com/dtolnay/rust-toolchain/releases) - [Commits](dtolnay/rust-toolchain@6d653ac...0f44b27) Updates `taiki-e/install-action` from 2.62.40 to 2.62.52 - [Release notes](https://github.com/taiki-e/install-action/releases) - [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/install-action@41ef8c6...537c30d) Updates `sarisia/actions-status-discord` from 1.15.4 to 1.15.5 - [Release notes](https://github.com/sarisia/actions-status-discord/releases) - [Commits](sarisia/actions-status-discord@11a0bfe...b8381b2) Updates `actions/dependency-review-action` from 45529485b5eb76184ced07362d2331fd9d26f03f to 125b99508212ce1cc3076ad60f6bd63bf6d88a66 - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@4552948...125b995) Updates `docker/setup-qemu-action` from 3.6.0 to 3.7.0 - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@2910929...c7c5346) Updates `docker/metadata-action` from 5.8.0 to 5.9.0 - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](docker/metadata-action@c1e5197...318604b) Updates `github/codeql-action` from 4.31.0 to 4.31.3 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4e94bd1...014f16e) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: dtolnay/rust-toolchain dependency-version: 0f44b27771c32bda9f458f75a1e241b09791b331 dependency-type: direct:production dependency-group: github-actions - dependency-name: taiki-e/install-action dependency-version: 2.62.52 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: sarisia/actions-status-discord dependency-version: 1.15.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: actions/dependency-review-action dependency-version: 125b99508212ce1cc3076ad60f6bd63bf6d88a66 dependency-type: direct:production dependency-group: github-actions - dependency-name: docker/setup-qemu-action dependency-version: 3.7.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: docker/metadata-action dependency-version: 5.9.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: github/codeql-action dependency-version: 4.31.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps debian from `78d2f66` to `936abff`. --- updated-dependencies: - dependency-name: debian dependency-version: bookworm-slim dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: fulmicoton <paul.masurel@datadoghq.com>
Bumps debian from `936abff` to `b4aa902`. --- updated-dependencies: - dependency-name: debian dependency-version: bookworm-slim dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the github-actions group with 4 updates: [actions/checkout](https://github.com/actions/checkout), [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain), [taiki-e/install-action](https://github.com/taiki-e/install-action) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/checkout` from 5.0.1 to 6.0.0 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93cb6ef...1af3b93) Updates `dtolnay/rust-toolchain` from 0f44b27771c32bda9f458f75a1e241b09791b331 to 0b1efabc08b657293548b77fb76cc02d26091c7e - [Release notes](https://github.com/dtolnay/rust-toolchain/releases) - [Commits](dtolnay/rust-toolchain@0f44b27...0b1efab) Updates `taiki-e/install-action` from 2.62.52 to 2.62.57 - [Release notes](https://github.com/taiki-e/install-action/releases) - [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/install-action@537c30d...763e332) Updates `github/codeql-action` from 4.31.3 to 4.31.5 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@014f16e...fdbfb4d) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: dtolnay/rust-toolchain dependency-version: 0b1efabc08b657293548b77fb76cc02d26091c7e dependency-type: direct:production dependency-group: github-actions - dependency-name: taiki-e/install-action dependency-version: 2.62.57 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: github/codeql-action dependency-version: 4.31.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump tantivy version * Update 3rd part license file --------- Co-authored-by: fulmicoton <paul.masurel@datadoghq.com>
* [ui] remove unused asset * [ui] avoid using automatically generated svg component (for the sake of having less non-standard configuration) * [ui] replace react-monaco-editor with @monaco-editor/react which seems to be the officially supported one * [ui] use vite for build and local dev server * [ui] run type checking on CI * [ui] eject from react-create-app and fix jest config * [ui] ensure install step is determinist * [ui] update readme * [ui] fix linting errors + replace eslint by biome * [ui] bump typescript version * [ui] bump react 19 * [ui] Avoid using loader-utils@0.2.17 , glob@10.4.5 , dompurify@3.1.7 which are flag as vulnerable
* Skipping running tantivy search if cannot do better. Also, - removes some noisy intermediary traces/span. - logs the ast/agg in the root node. - logs a summary about the split execution (cache, pruned, etc.) in the leaf node Co-authored-by: fulmicoton <paul.masurel@datadoghq.com>
Bumps [pprof](https://github.com/tikv/pprof-rs) from 0.13.0 to 0.14.0. - [Changelog](https://github.com/tikv/pprof-rs/blob/master/CHANGELOG.md) - [Commits](https://github.com/tikv/pprof-rs/commits) --- updated-dependencies: - dependency-name: pprof dependency-version: 0.14.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: Prefix and Wildcard in Elastic DSL Signed-off-by: Darkheir <raphael.cohen@sekoia.io> * chore: Add licence header Signed-off-by: Darkheir <raphael.cohen@sekoia.io> * feat: Add integration tests Signed-off-by: Darkheir <raphael.cohen@sekoia.io> * feat: Add support for short request format Signed-off-by: Darkheir <raphael.cohen@sekoia.io> * Apply PR review sugestion Signed-off-by: Darkheir <raphael.cohen@sekoia.io> --------- Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a search needs to process too many splits compared to the cluster capacity, we know upfront that it is pretty much impossible for the query to succeed. Instead of trusting resources for the whole duration of the configured timeout, this PR adds a node config to cancel these requests early (after the planning but before sending the jobs to the leafs).
How was this PR tested?
Unit test