Skip to content

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Sep 28, 2025

This PR contains the CHANGELOG for Node/Standalone with backward browser versions

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Consistency

Verify that all updated tags consistently use the new build date 20250909 and Grid version suffix 4.35.0-20250909 across every listed image tag variant and that no old 20250828 references remain.

./tag_and_push_browser_images.sh 4.35.0 20250909 selenium false chrome true
Tagging images for browser chrome, version 4.35.0, build date 20250909, namespace selenium
Selenium Grid version -> 4.35.0-20250909
Chrome version -> 100.0.4896.127
Short Chrome version -> 100.0
ChromeDriver version -> 100.0.4896.60
Short ChromeDriver version -> 100.0
Tagged selenium/node-chrome:100.0.4896.127-chromedriver-100.0.4896.60-grid-4.35.0-20250909
Tagged selenium/standalone-chrome:100.0.4896.127-chromedriver-100.0.4896.60-grid-4.35.0-20250909
Tagged selenium/node-chrome:100.0.4896.127-chromedriver-100.0.4896.60-20250909
Tagged selenium/standalone-chrome:100.0.4896.127-chromedriver-100.0.4896.60-20250909
Tagged selenium/node-chrome:100.0.4896.127-20250909
Tagged selenium/standalone-chrome:100.0.4896.127-20250909
Tagged selenium/node-chrome:100.0-chromedriver-100.0-grid-4.35.0-20250909
Tagged selenium/standalone-chrome:100.0-chromedriver-100.0-grid-4.35.0-20250909
Tagged selenium/node-chrome:100.0-chromedriver-100.0-20250909
Tagged selenium/standalone-chrome:100.0-chromedriver-100.0-20250909
Tagged selenium/node-chrome:100.0-20250909
Tagged selenium/standalone-chrome:100.0-20250909
Accuracy

Ensure Chrome and ChromeDriver versions shown did not change unintentionally; only the build date and Grid tag should have changed. Cross-check versions remain identical to prior entries.

Chrome version -> 118.0.5993.117
Short Chrome version -> 118.0
ChromeDriver version -> 118.0.5993.70
Short ChromeDriver version -> 118.0
Tagged selenium/node-chrome:118.0.5993.117-chromedriver-118.0.5993.70-grid-4.35.0-20250909
Tagged selenium/standalone-chrome:118.0.5993.117-chromedriver-118.0.5993.70-grid-4.35.0-20250909
Tagged selenium/node-chrome:118.0.5993.117-chromedriver-118.0.5993.70-20250909
Tagged selenium/standalone-chrome:118.0.5993.117-chromedriver-118.0.5993.70-20250909
Tagged selenium/node-chrome:118.0.5993.117-20250909
Tagged selenium/standalone-chrome:118.0.5993.117-20250909
Tagged selenium/node-chrome:118.0-chromedriver-118.0-grid-4.35.0-20250909
Tagged selenium/standalone-chrome:118.0-chromedriver-118.0-grid-4.35.0-20250909
Tagged selenium/node-chrome:118.0-chromedriver-118.0-20250909
Tagged selenium/standalone-chrome:118.0-chromedriver-118.0-20250909
Tagged selenium/node-chrome:118.0-20250909
Tagged selenium/standalone-chrome:118.0-20250909
Coverage

Confirm all intended version files (95–125, 134–138) were updated, including those not fully shown in the diff, and that Node and Standalone variants are present for each.

./tag_and_push_browser_images.sh 4.35.0 20250909 selenium false chrome true
Tagging images for browser chrome, version 4.35.0, build date 20250909, namespace selenium
Selenium Grid version -> 4.35.0-20250909
Chrome version -> 134.0.6998.165
Short Chrome version -> 134.0
ChromeDriver version -> 134.0.6998.165
Short ChromeDriver version -> 134.0
Tagged selenium/node-chrome:134.0.6998.165-chromedriver-134.0.6998.165-grid-4.35.0-20250909
Tagged selenium/standalone-chrome:134.0.6998.165-chromedriver-134.0.6998.165-grid-4.35.0-20250909
Tagged selenium/node-chrome:134.0.6998.165-chromedriver-134.0.6998.165-20250909
Tagged selenium/standalone-chrome:134.0.6998.165-chromedriver-134.0.6998.165-20250909
Tagged selenium/node-chrome:134.0.6998.165-20250909
Tagged selenium/standalone-chrome:134.0.6998.165-20250909
Tagged selenium/node-chrome:134.0-chromedriver-134.0-grid-4.35.0-20250909
Tagged selenium/standalone-chrome:134.0-chromedriver-134.0-grid-4.35.0-20250909
Tagged selenium/node-chrome:134.0-chromedriver-134.0-20250909
Tagged selenium/standalone-chrome:134.0-chromedriver-134.0-20250909
Tagged selenium/node-chrome:134.0-20250909
Tagged selenium/standalone-chrome:134.0-20250909

Copy link
Contributor

qodo-merge-pro bot commented Sep 28, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
High-level
Automate changelog generation to avoid manual updates

The current process of manually updating build dates across numerous changelog
files is inefficient. It should be automated via a script within the
build/release pipeline to ensure consistency and reduce manual work.

Examples:

CHANGELOG/4.35.0/chrome_100.md [1-21]

./tag_and_push_browser_images.sh 4.35.0 20250909 selenium false chrome true
Tagging images for browser chrome, version 4.35.0, build date 20250909, namespace selenium
Selenium Grid version -> 4.35.0-20250909
Chrome version -> 100.0.4896.127
Short Chrome version -> 100.0
ChromeDriver version -> 100.0.4896.60
Short ChromeDriver version -> 100.0
Tagged selenium/node-chrome:100.0.4896.127-chromedriver-100.0.4896.60-grid-4.35.0-20250909
Tagged selenium/standalone-chrome:100.0.4896.127-chromedriver-100.0.4896.60-grid-4.35.0-20250909

... (clipped 11 lines)

</details>



<details>
<summary>
<a href="https://github.com/SeleniumHQ/docker-selenium/pull/2965/files#diff-b32a89c2ebf6ba4db72212a5d5fcbaa26c4c3553391de971533265df43ba05c6R1-R21">CHANGELOG/4.35.0/chrome_125.md [1-21]</a>
</summary>



```markdown

./tag_and_push_browser_images.sh 4.35.0 20250909 selenium false chrome true
Tagging images for browser chrome, version 4.35.0, build date 20250909, namespace selenium
Selenium Grid version -> 4.35.0-20250909
Chrome version -> 125.0.6422.141
Short Chrome version -> 125.0
ChromeDriver version -> 125.0.6422.141
Short ChromeDriver version -> 125.0
Tagged selenium/node-chrome:125.0.6422.141-chromedriver-125.0.6422.141-grid-4.35.0-20250909
Tagged selenium/standalone-chrome:125.0.6422.141-chromedriver-125.0.6422.141-grid-4.35.0-20250909

... (clipped 11 lines)

</details>




### Solution Walkthrough:



#### Before:
```markdown
# For each of the 30+ changelog files:
# 1. Manually determine the new build date (e.g., 20250909)
# 2. Open a specific changelog file, e.g., 'chrome_100.md'
# 3. Manually find and replace all occurrences of the old date '20250828' with '20250909'.
#
# Example:
# -./tag_and_push_browser_images.sh 4.35.0 20250828 ...
# -Selenium Grid version -> 4.35.0-20250828
# -Tagged selenium/node-chrome:...-20250828
#
# becomes
#
# +./tag_and_push_browser_images.sh 4.35.0 20250909 ...
# +Selenium Grid version -> 4.35.0-20250909
# +Tagged selenium/node-chrome:...-20250909
#
# 4. Repeat for all other files.

After:

# A single script automates the update for all files.
# e.g., ./scripts/generate_changelogs.sh <version> <new_date>

#!/bin/bash
SELENIUM_VERSION=$1
BUILD_DATE=$2
CHANGELOG_DIR="CHANGELOG/${SELENIUM_VERSION}"

for file in $(ls ${CHANGELOG_DIR}/chrome_*.md); do
  # The script would generate the content from scratch based on templates
  # and data, rather than performing a simple find-and-replace on existing files.
  CHROME_VERSION=$(basename $file .md | cut -d'_' -f2)
  generate_changelog_content $SELENIUM_VERSION $BUILD_DATE $CHROME_VERSION > $file
done

echo "All changelogs updated automatically."
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies a highly manual and error-prone process and proposes automation, which would significantly improve the release workflow and maintainability.

Medium
  • Update

@selenium-ci selenium-ci force-pushed the browser-node-changelog branch from 435d0ca to c9dfa00 Compare September 29, 2025 06:05
….35.0

Browser versions: [98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142]
@selenium-ci selenium-ci force-pushed the browser-node-changelog branch from c9dfa00 to c7018a2 Compare September 29, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant