Revert "[java] make the signature change in ExecuteMethod backward compatible"#17184
Open
vaibhav09mbm wants to merge 1 commit intoSeleniumHQ:trunkfrom
Open
Conversation
…compatib…" This reverts commit bd280c7.
|
|
Contributor
Review Summary by QodoRevert ExecuteMethod backward compatibility changes and restore generic signatures
WalkthroughsDescription• Reverts backward compatibility changes to ExecuteMethod interface • Restores generic return type to execute() method signature • Removes three convenience methods: execute(String, Map, T), executeAs(), execute(String) • Introduces new executeRequired() method for non-null result handling • Updates all call sites to use executeRequired() where null-safety needed File Changes1. java/src/org/openqa/selenium/remote/ExecuteMethod.java
|
Contributor
Code Review by Qodo
1. ExecuteMethod helpers removed
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+40
to
44
| @Nullable <T> T execute(String commandName, @Nullable Map<String, ?> parameters); | ||
|
|
||
| /** | ||
| * Execute the given command and return the default value if the command return null. | ||
| * | ||
| * @return non-nullable value of type T. | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| default <T> T execute(String commandName, @Nullable Map<String, ?> parameters, T defaultValue) { | ||
| return (T) requireNonNullElse(execute(commandName, parameters), defaultValue); | ||
| } | ||
|
|
||
| /** | ||
| * Execute the given command and cast the returned value to T. | ||
| * | ||
| * @return non-nullable value of type T. | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| default <T> T executeAs(String commandName, @Nullable Map<String, ?> parameters) { | ||
| return (T) requireNonNull(execute(commandName, parameters)); | ||
| } | ||
|
|
||
| /** | ||
| * Execute the given command without parameters and cast the returned value to T. | ||
| * | ||
| * @return non-nullable value of type T. | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| default <T> T execute(String commandName) { | ||
| return (T) requireNonNull(execute(commandName, null)); | ||
| default <T> T executeRequired(String commandName, @Nullable Map<String, ?> parameters) { | ||
| return requireNonNull(execute(commandName, parameters)); | ||
| } |
Contributor
There was a problem hiding this comment.
1. executemethod helpers removed 📘 Rule violation ✓ Correctness
The public ExecuteMethod interface no longer exposes previously available convenience/default methods and changes the execute API shape, forcing downstream users to update code when upgrading Selenium. This is a breaking public API change and removes public functionality without a deprecation/migration period.
Agent Prompt
## Issue description
`ExecuteMethod` has changed in a way that breaks external consumers by removing previously available public convenience/default methods and forcing call sites to migrate immediately.
## Issue Context
This PR is required to maintain API/ABI compatibility for user-facing changes and to deprecate public functionality before removing it.
## Fix Focus Areas
- java/src/org/openqa/selenium/remote/ExecuteMethod.java[40-44]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #17183