Skip to content

Conversation

@sewnie
Copy link

@sewnie sewnie commented Apr 23, 2025

Here you go. makes your script less terrible. I also refactorized the script because:

  1. I do not like duplicated code
  2. I do not like seeing parameters such as cURL --fail be unused
  3. I do not like programs that have no mechanism to simply (note, simply, in bash, there is no goto) retry a request
  4. I do not like resource intensive code.

I also notice that the rest of the module's code and other scripts are written terribly, but those are out of scope, since they work.

@sewnie sewnie mentioned this pull request Apr 23, 2025
@becknik
Copy link

becknik commented Jul 29, 2025

Thanks for your work - I can confirm it works fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants