Migrate to the Options Pattern

[Sella-GH]

No description provided.

[Copilot]

Copilot reviewed 17 out of 32 changed files in this pull request and generated 1 comment.

Files not reviewed (15)

• Directory.Build.props: Language not supported
• src/AzzyBot.Bot/Modules/Core/Files/AppStats.json: Language not supported
• src/AzzyBot.Bot/Settings/AzzyBotSettings-Docker.json: Language not supported
• src/AzzyBot.Bot/Settings/AzzyBotSettings.json: Language not supported
• src/AzzyBot.Bot/Settings/AzzyBotSettingsRecord.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/GuildsAutocomplete.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/AdminCommands.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/AzzyHelpAutocomplete.cs: Evaluated as low risk
• src/AzzyBot.Bot/Services/DiscordBotService.cs: Evaluated as low risk
• src/AzzyBot.Bot/Services/DiscordEvents/DiscordGuildsHandler.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/CoreCommands.cs: Evaluated as low risk
• src/AzzyBot.Bot/Services/UpdaterService.cs: Evaluated as low risk
• src/AzzyBot.Bot/Services/Modules/CoreServiceHost.cs: Evaluated as low risk
• src/AzzyBot.Bot/Services/DiscordBotServiceHost.cs: Evaluated as low risk
• src/AzzyBot.Bot/Extensions/IServiceCollectionExtensions.cs: Evaluated as low risk

Comments suppressed due to low confidence (3)

src/AzzyBot.Bot/Settings/Validators/AppStatsValidator.cs:7

• The AppStatsValidator class should contain validation logic or at least a placeholder method to indicate that validation will be implemented.

public sealed partial class AppStatsValidator : IValidateOptions<AppStats>

src/AzzyBot.Bot/Settings/AzzyBotSettings.cs:49

• [nitpick] The variable name 'LavalinkPassword' might be unclear. Consider renaming it to something more descriptive like 'MusicStreamingPassword'.

public string? LavalinkPassword { get; set; } = "AzzyB0TMus1cStr3am!ng";

src/AzzyBot.Bot/Settings/AzzyBotSettings.cs:31

• [nitpick] The default value for 'Doing' might be too specific. Consider using a more generic default value like 'Idle'.

public string Doing { get; set; } = "Music";

[Copilot]

Copilot reviewed 17 out of 32 changed files in this pull request and generated 2 comments.

Files not reviewed (15)

• Directory.Build.props: Language not supported
• src/AzzyBot.Bot/Modules/Core/Files/AppStats.json: Language not supported
• src/AzzyBot.Bot/Settings/AzzyBotSettings-Docker.json: Language not supported
• src/AzzyBot.Bot/Settings/AzzyBotSettings.json: Language not supported
• src/AzzyBot.Bot/Settings/AzzyBotSettingsRecord.cs: Evaluated as low risk
• src/AzzyBot.Bot/Settings/AzzyBotSettings.cs: Evaluated as low risk
• src/AzzyBot.Bot/Settings/AppSettingsRecord.cs: Evaluated as low risk
• src/AzzyBot.Bot/Settings/Validators/AppStatsValidator.cs: Evaluated as low risk
• src/AzzyBot.Bot/Services/DiscordEvents/DiscordGuildsHandler.cs: Evaluated as low risk
• src/AzzyBot.Bot/Services/UpdaterService.cs: Evaluated as low risk
• src/AzzyBot.Bot/Services/DiscordBotServiceHost.cs: Evaluated as low risk
• src/AzzyBot.Bot/Services/Modules/CoreServiceHost.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/AdminCommands.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/GuildsAutocomplete.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/AzzyHelpAutocomplete.cs: Evaluated as low risk

Comments suppressed due to low confidence (4)

src/AzzyBot.Bot/Settings/Validators/AzzyBotSettingsValidator.cs:8

• The AppStatsValidator class is defined but does not contain any validation logic. Ensure that validation logic is implemented and covered by tests.

}

src/AzzyBot.Bot/Extensions/IServiceCollectionExtensions.cs:35

• Building a service provider within the ConfigureServices method can cause issues with the DI container, such as creating multiple instances of services that should be singletons. Consider refactoring this to avoid building the service provider.

IServiceProvider serviceProvider = services.BuildServiceProvider();

src/AzzyBot.Bot/Extensions/IServiceCollectionExtensions.cs:104

• The AddOptionsWithValidateOnStart method is not a standard method in the Microsoft.Extensions.DependencyInjection namespace. Ensure that this method is defined and correctly implemented, or replace it with the standard ValidateOnStart method.

services.AddSingleton<IValidateOptions<AzzyBotSettings>, AzzyBotSettingsValidator>().AddOptionsWithValidateOnStart<AzzyBotSettings>();

src/AzzyBot.Bot/Commands/CoreCommands.cs:113

• [nitpick] The class name CoreStats should be renamed to match the convention of using a noun or noun phrase, such as CoreStatistics, to improve clarity.

public sealed class CoreStats(AppStats stats, ILogger<CoreStats> logger)