Fix errors from last PR & some more

[Sella-GH]

No description provided.

Copilot reviewed 55 out of 70 changed files in this pull request and generated 2 comments.

Files not reviewed (15)

• Directory.Build.props: Language not supported
• src/AzzyBot.Bot/AzzyBot.Bot.csproj: Language not supported
• src/AzzyBot.Bot/Commands/Checks/AzuraCastDiscordChannelCheck.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Checks/ModuleActivatedCheckAttribute.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Checks/ModuleActivatedCheck.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Checks/AzuraCastOnlineCheck.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Checks/AzuraCastFeatureCheck.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Checks/AzuraCastDiscordPermCheck.cs: Evaluated as low risk
• CHANGELOG.md: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/AzuraCastSystemLogAutocomplete.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/AzuraCastCommands.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/AzuraCastRequestAutocomplete.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/AzuraCastMountAutocomplete.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/AzuraCastStationsAutocomplete.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/AzuraCastPlaylistAutocomplete.cs: Evaluated as low risk

Comments suppressed due to low confidence (6)

src/AzzyBot.Bot/Commands/ConfigCommands.cs:90

• The removal of await context.DeferResponseAsync(); might affect the responsiveness of the bot, especially for long-running operations. Consider keeping it to ensure a responsive user experience.

await context.DeferResponseAsync();

src/AzzyBot.Bot/Commands/ConfigCommands.cs:536

• The removal of await context.DeferResponseAsync(); might affect the responsiveness of the bot, especially for long-running operations. Consider keeping it to ensure a responsive user experience.

await context.DeferResponseAsync();

src/AzzyBot.Bot/Commands/ConfigCommands.cs:568

• The removal of await context.DeferResponseAsync(); might affect the responsiveness of the bot, especially for long-running operations. Consider keeping it to ensure a responsive user experience.

await context.DeferResponseAsync();

src/AzzyBot.Bot/Commands/ConfigCommands.cs:633

• The removal of await context.DeferResponseAsync(); might affect the responsiveness of the bot, especially for long-running operations. Consider keeping it to ensure a responsive user experience.

await context.DeferResponseAsync();

legal/Terms-Of-Service.md:12

• The effective date should refer to the Terms of Service Agreement, not the Privacy Policy. It should be corrected to 'This Terms of Service Agreement is effective as of 2024-12-22.'

This Privacy Policy is effective as of 2024-12-22.

src/AzzyBot.Bot/Commands/AdminCommands.cs:182

• [nitpick] The error message 'NoGuildFound' is unclear. It should be more descriptive, such as 'No guilds found to reset legals for'.

await context.EditResponseAsync(GeneralStrings.NoGuildFound);

[Copilot]

Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (6)

• CHANGELOG.md: Evaluated as low risk
• src/AzzyBot.Bot/Services/CronJobs/AzzyBotGlobalChecksJob.cs: Evaluated as low risk
• src/AzzyBot.Data/Services/DbActions.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/CoreCommands.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/MusicStreamingCommands.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/AzuraCastMountAutocomplete.cs: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/AzzyBot.Bot/Commands/Autocompletes/AzuraCastStationsAutocomplete.cs:65

• [nitpick] The error message could be clearer by including the station name or ID directly in the message.

await _botService.SendMessageAsync(azuraCast.Preferences.NotificationChannelId, $"I don't have the permission to access the **station** ({station}) endpoint.\n{AzuraCastApiService.AzuraCastPermissionsWiki}");

Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (7)

• src/AzzyBot.Data/Services/DbActions.cs: Evaluated as low risk
• legal/Terms-Of-Service.md: Evaluated as low risk
• src/AzzyBot.Bot/Commands/CoreCommands.cs: Evaluated as low risk
• src/AzzyBot.Bot/Commands/MusicStreamingCommands.cs: Evaluated as low risk
• src/AzzyBot.Bot/Services/CronJobs/AzzyBotGlobalChecksJob.cs: Evaluated as low risk
• CHANGELOG.md: Evaluated as low risk
• src/AzzyBot.Bot/Commands/Autocompletes/AzuraCastMountAutocomplete.cs: Evaluated as low risk

Comments suppressed due to low confidence (2)

src/AzzyBot.Bot/Commands/Autocompletes/AzuraCastSystemLogAutocomplete.cs:52

• [nitpick] The error message could be more specific. Suggest changing to: "I don't have the permission to access the system logs endpoint for administrative purposes.\n{AzuraCastApiService.AzuraCastPermissionsWiki}"

await _botService.SendMessageAsync(azuraCast.Preferences.NotificationChannelId, "I don't have the permission to access the administrative **system logs** endpoint.\n{AzuraCastApiService.AzuraCastPermissionsWiki}");

src/AzzyBot.Bot/Commands/Autocompletes/AzuraCastStationsAutocomplete.cs:65

• [nitpick] The error message is clear and helpful. Ensure that the station variable is correctly formatted in the message.

await _botService.SendMessageAsync(azuraCast.Preferences.NotificationChannelId, "I don't have the permission to access the **station** ({station}) endpoint.\n{AzuraCastApiService.AzuraCastPermissionsWiki}");