StepRunner: ignore archived reagent kits when adding default reagents to a step #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallsco
force-pushed
the
ignore_archived_kits
branch
from
498569d to
d90ca61
Compare
HernanRossi
approved these changes
Jun 19, 2024
smallsco
force-pushed
the
ignore_archived_kits
branch
from
d90ca61 to
582f331
Compare
… when combining Python automations with LLTK/LITKs
smallsco
force-pushed
the
ignore_archived_kits
branch
2 times, most recently
from
53f5d6b to
92e9d4b
Compare
smallsco
force-pushed
the
ignore_archived_kits
branch
from
92e9d4b to
2c7d19e
Compare
Merged
smallsco
added a commit
that referenced
this pull request
Jul 19, 2024
* Updated version.py and changelog for 1.6.0 release * Declare support for Python 3.12 in setup.py (#60) * Fix EPP log message duplication and missing log entries in Clarity 6+ when combining Python automations with LLTK/LITKs (#51) * Fix EPP log message duplication and missing log entries in Clarity 6+ when combining Python automations with LLTK/LITKs * Fix current_minor_version failure on Python 2 * StepRunner: ignore archived reagent kits when adding default reagents to a step (#53) * Fix EPP log message duplication and missing log entries in Clarity 6+ when combining Python automations with LLTK/LITKs * Fix current_minor_version failure on Python 2 * StepRunner: ignore archived reagent kits when adding default reagents to a step * check for placement node that matches uri before creating one (#55) * check for placement node that matches uri before creating one * add missing quotes, fix for py2 * remove f * Fix coveralls on Python 3.6 (#52) * Enable automated unit testing with Python 3.12 (#56) * Fix coveralls on Python 3.6 * Enable automated unit testing with Python 3.12 * Only trigger a production PyPi build on tags using semantic versioning (#57) * Use latest versions of GitHub workflow actions, build with Python 3.12 (#58) * Enable automated unit testing for Python 3.5 (#59) * Fix coveralls parallel builds (#61) --------- Co-authored-by: Scott Small <scott.small@semaphoresolutions.ca> --------- Co-authored-by: Joe Rickwalder <jrickwalder@billiontoone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a reagent kit is associated to a step, and is later archived, then when running the step manually using the Clarity GUI, the reagent kit will (correctly) not be shown on the step's Record Details screen.
However, the association between the step and archived kit is retained, and when making an API request using something like self.step.configuration.required_reagent_kits, the archived kit will be returned by the API.
If the API is then used to add a lot to the archived kit on the step, and advance the step, the Clarity API will correctly - but confusingly - return an error stating that the reagent kit is not permitted for the step.
This patch modifies the add_default_reagents() function of the StepRunner to ignore any reagent kits found on the step that are archived, instead of adding a lot to them. This prevents workflow tests from suddenly breaking because a customer decided to archive a reagent kit without removing it from a step first.