Skip to content

Refactor default player app parsing in CLI#178

Merged
maximmaxim345 merged 1 commit intoSendspin:mainfrom
balloob-travel:codex/fix-cli-app-ordering
Mar 10, 2026
Merged

Refactor default player app parsing in CLI#178
maximmaxim345 merged 1 commit intoSendspin:mainfrom
balloob-travel:codex/fix-cli-app-ordering

Conversation

@balloob-travel
Copy link
Contributor

Summary

  • make player a real subparser and inject it when no app is specified
  • let argparse reject flags placed before explicit apps like daemon
  • document the app ordering rule in the README

as reported in #175

Verification

  • uv run ruff check sendspin/cli.py
  • direct parse_args smoke check for sendspin, sendspin --url ..., sendspin daemon --url ..., and invalid sendspin --url ... daemon

@balloob-travel balloob-travel changed the title Refactor default player app parsing Refactor default player app parsing in CLI Mar 10, 2026
@maximmaxim345 maximmaxim345 merged commit 9cc34bb into Sendspin:main Mar 10, 2026
1 check passed
@maximmaxim345 maximmaxim345 added the maintenance This PR does maintenance on the Code label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance This PR does maintenance on the Code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants