Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logos with different sizes added #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mnosov622
Copy link

Fixes #14

I created logo for the My-photohub project. Created different sizes. All logos are in svg format.

Copy link
Collaborator

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these load for me in Chrome on macOS:

Screen Shot 2022-12-01 at 7 05 15 PM

Also, we'll need other formats besides SVG, as not every place we'd need to use this accepts SVG as the time (e.g., favicon). See https://www.simicart.com/blog/pwa-manifest/?simipwa=1 for help.

@mnosov622
Copy link
Author

None of these load for me in Chrome on macOS:

Screen Shot 2022-12-01 at 7 05 15 PM

Also, we'll need other formats besides SVG, as not every place we'd need to use this accepts SVG as the time (e.g., favicon). See https://www.simicart.com/blog/pwa-manifest/?simipwa=1 for help.

That's weird. If we open them in the browser, you can see them. I'm, not sure why is that happening :(

What other formats are needed ? PNG ?

@SerpentBytes SerpentBytes added the ✨ enhancement New feature or request label Dec 4, 2022
@SerpentBytes
Copy link
Collaborator

SerpentBytes commented Dec 6, 2022

What other formats are needed ? PNG ?

Maybe PNG, or JPEG, at the very least. See this link here, it lists common file formats for logos.

@mnosov622
Copy link
Author

mnosov622 commented Dec 6, 2022 via email

@mnosov622
Copy link
Author

Hi guys,

Since we decided to go with another logo, I will upload new images to this PR.

@mnosov622
Copy link
Author

For some reason, svg logos are not loading properly, but the are visible when we open them in browser
image

@mnosov622 mnosov622 requested review from humphd and removed request for CDPhu December 8, 2022 01:17
@SerpentBytes SerpentBytes self-requested a review December 10, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design: Come up with a creative icon related to photos rather than using React icon
6 participants