-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logos with different sizes added #29
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these load for me in Chrome on macOS:
Also, we'll need other formats besides SVG, as not every place we'd need to use this accepts SVG as the time (e.g., favicon). See https://www.simicart.com/blog/pwa-manifest/?simipwa=1 for help.
That's weird. If we open them in the browser, you can see them. I'm, not sure why is that happening :( What other formats are needed ? PNG ? |
Maybe PNG, or JPEG, at the very least. See this link here, it lists common file formats for logos. |
Got it, thank you so much !
…On Tue, Dec 6, 2022, 1:28 PM TD ***@***.***> wrote:
What other formats are needed ? PNG ?
Maybe PNG, JPEG, at the very least. See this link here
<https://www.upwork.com/resources/logo-file-format>, it lists common file
formats for logo.
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARNN2PUTS234DF2T5UTNFLDWL6AVFANCNFSM6AAAAAASRK3CSI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Hi guys, Since we decided to go with another logo, I will upload new images to this PR. |
Fixes #14
I created logo for the My-photohub project. Created different sizes. All logos are in svg format.