Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Header for the web app #70

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Created Header for the web app #70

wants to merge 3 commits into from

Conversation

Abbas-shamshi
Copy link
Collaborator

Pull Request

Description

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Code Style

  • The commit message follows our guidelines
  • My code follows the code style of this project.
  • Fixed merge conflicts with Master branch as base.

Documentation

  • My change requires a change to the documentation.
  • Docs have been added / updated (for bug fixes / features)
  • I have updated the documentation accordingly.

Tests

  • Compiles and passes lint tests
  • All existing tests passed.
  • Github Actions
  • Travis CI
  • I have added tests to cover my changes.

Behavior

Fixes #...

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Tested Checklist

  • Desktop
  • iPhone
  • Android
  • Apple Watch
  • iPhone 11 Simulator
  • iPhone X Simulator
  • iPhone 8 Simulator
  • Simulator

Other information

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

Note: for PR Review
This repository's PRs would be peer reviewed and then 1 approving reviewer is needed to merge code with master branch.

  • I have read the CONTRIBUTING document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant