Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/pagination #25

Closed
wants to merge 9 commits into from
Closed

Fix/pagination #25

wants to merge 9 commits into from

Conversation

TrevorBurgoyne
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne commented Oct 24, 2024 •
edited
Loading

Fix pagination

What?

  • Fix pagination for get_children_from_s3. Previously the call would only return up to 1000 items.
  • Add poetry install and reformat pyproject.toml
  • Modify gha tagging and releases
  • Add pre-commit checks

Checks:

  • Merged latest master
  • Updated README.md (if needed)
  • Changed version number in S3MP/_version.py and pyproject.toml
  • Packages match in environment.yml and pyproject.toml

@github-actions github-actions bot added the bug Something isn't working label Oct 24, 2024
@TrevorBurgoyne
Copy link
Member Author

poetry hates having S3MP instead of s3mp so abandoning this

@TrevorBurgoyne TrevorBurgoyne deleted the fix/pagination branch October 25, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TrevorBurgoyne