Sourcery Refactor (Includes #197) #198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sourcery refactored main branch
failsave checking for "hits" in json dict
|
Hmm, some of these were quite nice cleanups, but some I'm a bit unsure of. I usually want to keep the if-statements short, and rather have short lines than long lines. I might go through these and remove and change the refactoring which isn't used. |
|
There's absolutely no obligation to use any of this, the code is fine as is. I just like being reminded of where code i use can be improved/rethought ^^ |
Update actions/checkout action to v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Testing
Checklist
Related Issues
Fixes