Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PoorCode.html #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update to PoorCode.html #28

wants to merge 2 commits into from

Conversation

Andrena1
Copy link

I added comments to the evaluateConditions method

@Andrena1
Update to PoorCode.html
8893f16 
I added comments to the evaluateConditions method
@SergeyOvchinnik
Copy link
Owner

The comment is useful, but how about also simplifying the structure of the function?

@Andrena1
Update PoorCode.html
6ba831b 
I simplified the function and edited the comment again
@Andrena1
Copy link
Author

Please check, I have simplified the structure of the function. Thanks

@SergeyOvchinnik
Copy link
Owner

Looks better, there is only one thing missing now. Your implementation returns false for all negative values of c. However, the original implementation would return true if c is negative and a is not equal to b. Please make sure the logic of the new method corresponds to the logic of the original method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andrena1 @SergeyOvchinnik