Skip to content

Conversation

@morningstarxcdcode
Copy link

this repo is with no erros best bro
but I am making the codebase cleaner and more reliable:

  • Formatted all Python files using Black for consistent style.
  • Added or updated docstrings for all public classes and functions to improve clarity.
  • Included complete and accurate type hints throughout the code.
  • Improved error handling for model and tokenizer loading with clear, helpful messages.
  • Removed any unused imports and cleaned up the code to follow PEP8 best practices.

basically just enchanted the files no thing more ok yes....

Copy link
Collaborator

@ZackHodari ZackHodari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR was just the black linting then we could land it. See note below about CI/CD

  • try-except with generic Exception does not add utility, especially for a CLI tool like this repo
  • I'd prefer to follow the clean code principle of better naming rather than adding comments. Some of your comments also remove previous notes that were valuable
  • I appreciate the black linting, we could land this but feels like bad practice to do so without adding CI/CD to enforce this on future commits. This repo is unlikely to change much so seems like it's not that useful an endeavor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants