Events #34
Open
Events #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sriram1593, @varshaan, @vsvrp-1995, @surajy123 : Check for comments on your code. |
|
Hey, can images be removed from tracking ? |
|
@sriram1593, @varshaan, @vsvrp-1995, @surajy123 : Please merge the master branch into the events branch in your locahost, fix the merge conflicts and push. |
|
@karthikabinav : Yeah, done. |
| dajax.assign("#summary",'innerHTML',"<table border='1'><thead><tr><th>S.No</th><th>Group Name</th><th>Cores</th></tr></thead><tbody id='groups'>") | ||
| groups=Group.objects.order_by('id').all()[1:] | ||
| dajax.assign("#summary",'innerHTML',"<table border='1' class='table table-striped table-bordered table-condensed'><thead><tr><th>S.No</th><th>Group Name</th><th>Cores</th></tr></thead><tbody id='groups'>") | ||
| groups=Group.objects.order_by('id').all() |
There was a problem hiding this comment.
Whitespaces.
groups = Group.objects.order_by('id').all()
|
@akshayrangasai: Review front end code. |
| cache.set(str(unsaved_tab.id)+"_event", str(unsaved_tab.event), 2592000) | ||
| cache.set(str(unsaved_tab.id)+"_title", str(unsaved_tab.title), 2592000) | ||
| cache.set(str(unsaved_tab.id)+"_text", str(unsaved_tab.text), 2592000) | ||
| cache.set(str(unsaved_tab.id)+"_pref", str(unsaved_tab.pref), 2592000) |
There was a problem hiding this comment.
This should be done in the save method of the Tab model.
|
Also. We should really not be merging 250 commits at once. Please merge when the branch is done. Branch, add a small feature and merge it back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@karthikabinav, @meetaw, @praveenv253 : Please review the code. I'll do the same.